Commit 20703877 authored by lshang's avatar lshang Committed by Commit bot

Remove embedder param for SetNotificationSettingForOrigin

Notifications content settings don't consider the embedding origin
when updating the content setting values. Remove unused embedder
param in SetNotificationSettingForOrigin.

Review-Url: https://codereview.chromium.org/2035323002
Cr-Commit-Position: refs/heads/master@{#398180}
parent 2fdc0733
...@@ -22,6 +22,6 @@ public class NotificationInfo extends PermissionInfo { ...@@ -22,6 +22,6 @@ public class NotificationInfo extends PermissionInfo {
protected void setNativePreferenceValue( protected void setNativePreferenceValue(
String origin, String embedder, ContentSetting value, boolean isIncognito) { String origin, String embedder, ContentSetting value, boolean isIncognito) {
WebsitePreferenceBridge.nativeSetNotificationSettingForOrigin( WebsitePreferenceBridge.nativeSetNotificationSettingForOrigin(
origin, embedder, value.toInt(), isIncognito); origin, value.toInt(), isIncognito);
} }
} }
...@@ -258,7 +258,7 @@ public abstract class WebsitePreferenceBridge { ...@@ -258,7 +258,7 @@ public abstract class WebsitePreferenceBridge {
static native int nativeGetNotificationSettingForOrigin( static native int nativeGetNotificationSettingForOrigin(
String origin, boolean isIncognito); String origin, boolean isIncognito);
static native void nativeSetNotificationSettingForOrigin( static native void nativeSetNotificationSettingForOrigin(
String origin, String embedder, int value, boolean isIncognito); String origin, int value, boolean isIncognito);
private static native void nativeGetProtectedMediaIdentifierOrigins(Object list); private static native void nativeGetProtectedMediaIdentifierOrigins(Object list);
static native int nativeGetProtectedMediaIdentifierSettingForOrigin( static native int nativeGetProtectedMediaIdentifierSettingForOrigin(
String origin, String embedder, boolean isIncognito); String origin, String embedder, boolean isIncognito);
......
...@@ -322,7 +322,6 @@ static void SetNotificationSettingForOrigin( ...@@ -322,7 +322,6 @@ static void SetNotificationSettingForOrigin(
JNIEnv* env, JNIEnv* env,
const JavaParamRef<jclass>& clazz, const JavaParamRef<jclass>& clazz,
const JavaParamRef<jstring>& origin, const JavaParamRef<jstring>& origin,
const JavaParamRef<jstring>& embedder,
jint value, jint value,
jboolean is_incognito) { jboolean is_incognito) {
// Note: Web Notification permission behaves differently from all other // Note: Web Notification permission behaves differently from all other
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment