[FragmentItem] Distinguish to include culled inlines or not
Before moving to |NGInlineCursor|: * |InlineFragmentsFor| returns nothing for culled inlines. * |SelfFragmentsOf| returns relevant fragments for culled inlines. But both were moved to |NGInlineCursor|. This patch reviews all changes and re-distinguish them. Following usages were |SelfFragmentsOf|, changed to use the new function |MoveToIncludingCulledInline|. https://chromium-review.googlesource.com/c/chromium/src/+/1862534 |FirstLineBoxTopLeftInternal| |HitTestCulledInline| |PhysicalLinesBoundingBox| * |CollectLineBoxRects| uses different code path by |LayoutNGFragmentItemEnabled|, so no need to change for now. https://chromium-review.googlesource.com/c/chromium/src/+/1888623 |LinesVisualOverflowBoundingBox| Following usages were |InlineFragmentsFor|, keep using |MoveTo|. It was changed to return empty for culled inlines. https://chromium-review.googlesource.com/c/chromium/src/+/2022447 LayoutInline::NodeAtPoint https://chromium-review.googlesource.com/c/chromium/src/+/1888623 LinesVisualOverflowBoundingBox https://chromium-review.googlesource.com/c/chromium/src/+/1930287 InvalidateDisplayItemClients Bug: 982194 Change-Id: I4ea181606671a18b6337b7e651916be6ff5d1a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166233Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#762784}
Showing
Please register or sign in to comment