Commit 208fc27a authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in...

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/enterprise_platform_keys_private.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=drcrash@chromium.org

Bug: 925652
Change-Id: I526eef912697ba8dad512de35f88cf841950c068
Reviewed-on: https://chromium-review.googlesource.com/c/1438370Reviewed-by: default avatarYves Arrouye <drcrash@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628520}
parent a0273708
...@@ -374,7 +374,7 @@ TEST_P(EPKPChallengeMachineKeyAllProfilesTest, Success) { ...@@ -374,7 +374,7 @@ TEST_P(EPKPChallengeMachineKeyAllProfilesTest, Success) {
EXPECT_EQ("cmVzcG9uc2U=" /* Base64 encoding of 'response' */, response); EXPECT_EQ("cmVzcG9uc2U=" /* Base64 encoding of 'response' */, response);
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
AllProfiles, AllProfiles,
EPKPChallengeMachineKeyAllProfilesTest, EPKPChallengeMachineKeyAllProfilesTest,
::testing::Values(EPKPChallengeKeyTestBase::ProfileType::USER_PROFILE, ::testing::Values(EPKPChallengeKeyTestBase::ProfileType::USER_PROFILE,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment