Using SharedGpuContext when using a WebGL context for SendNewFrame.
The ReadARGBPixelsAsync expects that the Context being passed in has a RasterInterface. In the 3D path (WebGL), due to current limitations, there is a copy of the internal texture being made, encapsulated into an external canvas resource, and provided with a Context that does not have a RasterInterface. This CL adds an special handling for the WebGL offscreenCanvas case, and it gets the SharedGPUContext to produce the rendering, to avoid using the one provided from the image. As this CL is handling a Crash in a corner case in WebGL it has been proven hard to find a proper test for this. I'm adding a new DCHECK to make this more robust. Bug: 1148345 Change-Id: I7aff4bf7182233543533c33c42bfd4a36a7d4a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535892Reviewed-by:Yi Xu <yiyix@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#827774}
Showing
Please register or sign in to comment