Commit 2126b752 authored by W. James MacLean's avatar W. James MacLean Committed by Commit Bot

Reenable AppViewTest.TestAppViewMultipleConnects for the /1 case.

Since (i) this test seems to run fine for the /1 parameter case, and
(ii) the /1 parameter case represents the default configuration for
chrome as of M63, let's only disable the test for the failing
configuration, /0.

TBR=kbr@chromium.org

Bug: 794490
Change-Id: Id1ab8dcfdafecafca138d42a9b3d3401f5d7d203
Reviewed-on: https://chromium-review.googlesource.com/830709Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524495}
parent b0722ecf
...@@ -196,8 +196,13 @@ IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewGoodDataShouldSucceed) { ...@@ -196,8 +196,13 @@ IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewGoodDataShouldSucceed) {
} }
// Tests that <appview> correctly handles multiple successive connects. // Tests that <appview> correctly handles multiple successive connects.
// TODO(crbug.com/794490) Reenable after fixing timeout issues. IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewMultipleConnects) {
IN_PROC_BROWSER_TEST_P(AppViewTest, DISABLED_TestAppViewMultipleConnects) { // TODO(crbug.com/794490) Skip this test for the BrowserPlugin ("/0")
// case until we either (i) find the cause of the TIMEOUT or (ii)
// remove BrowserPlugin.
if (!GetParam())
return;
const extensions::Extension* skeleton_app = const extensions::Extension* skeleton_app =
InstallPlatformApp("app_view/shim/skeleton"); InstallPlatformApp("app_view/shim/skeleton");
TestHelper("testAppViewMultipleConnects", TestHelper("testAppViewMultipleConnects",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment