Commit 215847e9 authored by Patrick Monette's avatar Patrick Monette Committed by Commit Bot

Augment the ThirdPartyConflictsManager state to include features status

Bug: 846953
Change-Id: I6ee9d0d9557fa981726316994661ac0aad3c9631
Reviewed-on: https://chromium-review.googlesource.com/1135696
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: default avatarChris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574928}
parent 54aa1bf7
...@@ -305,7 +305,13 @@ void ThirdPartyConflictsManager::InitializeIfReady() { ...@@ -305,7 +305,13 @@ void ThirdPartyConflictsManager::InitializeIfReady() {
module_list_filter_, *installed_applications_); module_list_filter_, *installed_applications_);
} }
SetTerminalState(State::kInitialized); if (!incompatible_applications_updater_) {
SetTerminalState(State::kBlockingInitialized);
} else if (!module_blacklist_cache_updater_) {
SetTerminalState(State::kWarningInitialized);
} else {
SetTerminalState(State::kWarningAndBlockingInitialized);
}
} }
void ThirdPartyConflictsManager::OnModuleBlacklistCacheUpdated( void ThirdPartyConflictsManager::OnModuleBlacklistCacheUpdated(
......
...@@ -87,10 +87,13 @@ class ThirdPartyConflictsManager ...@@ -87,10 +87,13 @@ class ThirdPartyConflictsManager
// The initialization failed because there was no Module List version // The initialization failed because there was no Module List version
// available to install. // available to install.
kNoModuleListAvailableFailure, kNoModuleListAvailableFailure,
// The instance is initialized. If their respective feature is enabled, the // Only the IncompatibleApplicationsWarning feature is enabled and active.
// |incompatible_applications_updater_| & |module_blacklist_cache_updater_| kWarningInitialized,
// instances are initialized. // Only the ThirdPartyModulesBlocking feature is enabled and active.
kInitialized, kBlockingInitialized,
// Both the IncompatibleApplicationsWarning and ThirdPartyModulesBlocking
// features are enabled and active.
kWarningAndBlockingInitialized,
// The instance is about to be deleted. // The instance is about to be deleted.
kDestroyed, kDestroyed,
}; };
......
...@@ -100,7 +100,7 @@ TEST_F(ThirdPartyConflictsManagerTest, InitializeBothUpdaters) { ...@@ -100,7 +100,7 @@ TEST_F(ThirdPartyConflictsManagerTest, InitializeBothUpdaters) {
ASSERT_TRUE(final_state().has_value()); ASSERT_TRUE(final_state().has_value());
EXPECT_EQ(final_state().value(), EXPECT_EQ(final_state().value(),
ThirdPartyConflictsManager::State::kInitialized); ThirdPartyConflictsManager::State::kWarningAndBlockingInitialized);
} }
TEST_F(ThirdPartyConflictsManagerTest, InvalidModuleList) { TEST_F(ThirdPartyConflictsManagerTest, InvalidModuleList) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment