Commit 21715f31 authored by Jennifer Apacible's avatar Jennifer Apacible Committed by Commit Bot

[Picture in Picture] Disable context menu PIP command.

This is temporary while PIP is being wired up and worked to be more
stable through the media controls entry point.

The menu item is not removed because we intend to continue using it
and it is currently hidden behind a flag.

BUG: 817598
Change-Id: I9156d81b40dd6c97e19c6eef3f5fbbe13e350639
Reviewed-on: https://chromium-review.googlesource.com/942305
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540246}
parent 4ffbfebb
......@@ -2614,10 +2614,10 @@ void RenderViewContextMenu::ExecPictureInPicture() {
if (!base::FeatureList::IsEnabled(media::kPictureInPicture))
return;
PictureInPictureWindowController* window_controller =
PictureInPictureWindowController::GetOrCreateForWebContents(
embedder_web_contents_);
window_controller->Show();
// TODO(apacible): Re-enable contextual menu entry point for
// Picture-in-Picture after end to end flow through the media controls is
// stable. http://crbug/817613.
NOTIMPLEMENTED();
}
void RenderViewContextMenu::WriteURLToClipboard(const GURL& url) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment