Remove incognito temporary whitelist.

Incognito temporary whitelist and the last item in it are removed.
All items in the list were audited and removed before and the list is
no more in use.

Bug: 861722
Change-Id: I2922c3010efe3685beff59271294669affa93af5
Reviewed-on: https://chromium-review.googlesource.com/c/1256684Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596522}

chrome/browser/prefs/pref_service_incognito_whitelist.cc

@@ -202,16 +202,6 @@ const char* const kPersistentPrefNames[] = {
     variations::prefs::kVariationsSeedSignature,
 };
 
-// TODO(https://crbug.com/861722): Remove this list.
-// WARNING: PLEASE DO NOT ADD ANYTHING TO THIS LIST.
-// This list is temporarily added for transition of incognito preferences
-// storage default, from on disk to in memory. All items in this list will be
-// audited, checked with owners, and removed or transfered to
-// |kPersistentPrefNames|.
-const char* const kTemporaryIncognitoWhitelist[] = {
-    prefs::kClearPluginLSODataEnabled,
-};
-
 }  // namespace
 
 namespace prefs {
@@ -220,12 +210,6 @@ std::vector<const char*> GetIncognitoPersistentPrefsWhitelist() {
   std::vector<const char*> whitelist;
   whitelist.insert(whitelist.end(), kPersistentPrefNames,
                    kPersistentPrefNames + base::size(kPersistentPrefNames));
-
-  // TODO(https://crbug.com/861722): Remove after the list is audited and
-  // emptied.
-  whitelist.insert(
-      whitelist.end(), kTemporaryIncognitoWhitelist,
-      kTemporaryIncognitoWhitelist + base::size(kTemporaryIncognitoWhitelist));
   return whitelist;
 }
 

chrome/browser/prefs/pref_service_syncable_util.cc

@@ -28,9 +28,6 @@ CreateIncognitoPrefServiceSyncable(
     sync_preferences::PrefServiceSyncable* pref_service,
     PrefStore* incognito_extension_pref_store,
     std::unique_ptr<PrefValueStore::Delegate> delegate) {
-  // TODO(https://crbug.com/861722): Current implementation does not cover
-  // preferences from iOS. The code should be refactored to cover it. e.g. Moved
-  // to components/ so it can be used on iOS.
 
   return pref_service->CreateIncognitoPrefService(
       incognito_extension_pref_store,