Commit 219d99a6 authored by vabr's avatar vabr Committed by Commit bot

Remove checks for a crasher in PasswordForm.

The associated bug got closed, the crash is no longer observed since version
43, so the checks are overdue to be removed.

BUG=486931,510952
R=vasilii@chromium.org

Review URL: https://codereview.chromium.org/1636813003

Cr-Commit-Position: refs/heads/master@{#371507}
parent 9a1c85fb
...@@ -152,8 +152,7 @@ void ManagePasswordsState::OnAutomaticPasswordSave( ...@@ -152,8 +152,7 @@ void ManagePasswordsState::OnAutomaticPasswordSave(
void ManagePasswordsState::OnPasswordAutofilled( void ManagePasswordsState::OnPasswordAutofilled(
const PasswordFormMap& password_form_map, const PasswordFormMap& password_form_map,
const GURL& origin) { const GURL& origin) {
// TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed. DCHECK(!password_form_map.empty());
CHECK(!password_form_map.empty());
ClearData(); ClearData();
if (password_form_map.begin()->second->is_public_suffix_match) { if (password_form_map.begin()->second->is_public_suffix_match) {
// Don't show the UI for PSL matched passwords. They are not stored for this // Don't show the UI for PSL matched passwords. They are not stored for this
......
...@@ -83,13 +83,10 @@ PasswordForm::PasswordForm() ...@@ -83,13 +83,10 @@ PasswordForm::PasswordForm()
skip_zero_click(false), skip_zero_click(false),
layout(Layout::LAYOUT_OTHER), layout(Layout::LAYOUT_OTHER),
was_parsed_using_autofill_predictions(false), was_parsed_using_autofill_predictions(false),
is_alive(true),
is_public_suffix_match(false), is_public_suffix_match(false),
is_affiliation_based_match(false) {} is_affiliation_based_match(false) {}
PasswordForm::~PasswordForm() { PasswordForm::~PasswordForm() {
CHECK(is_alive);
is_alive = false;
} }
bool PasswordForm::IsPossibleChangePasswordForm() const { bool PasswordForm::IsPossibleChangePasswordForm() const {
......
...@@ -259,9 +259,6 @@ struct PasswordForm { ...@@ -259,9 +259,6 @@ struct PasswordForm {
// If true, this form was parsed using Autofill predictions. // If true, this form was parsed using Autofill predictions.
bool was_parsed_using_autofill_predictions; bool was_parsed_using_autofill_predictions;
// TODO(vabr): Remove |is_alive| once http://crbug.com/486931 is fixed.
bool is_alive; // Set on construction, reset on destruction.
// If true, this match was found using public suffix matching. // If true, this match was found using public suffix matching.
bool is_public_suffix_match; bool is_public_suffix_match;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment