Commit 21a2f228 authored by Xiyuan Xia's avatar Xiyuan Xia Committed by Commit Bot

Dump git command error instead of silent fail

Bug: 747349
Change-Id: Ied3abb6f93a391bf6581275efbd96b3763413de9
Reviewed-on: https://chromium-review.googlesource.com/976540Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarAchuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546109}
parent 16d1560d
...@@ -8,6 +8,7 @@ lastchange.py -- Chromium revision fetching utility. ...@@ -8,6 +8,7 @@ lastchange.py -- Chromium revision fetching utility.
""" """
import re import re
import logging
import optparse import optparse
import os import os
import subprocess import subprocess
...@@ -42,7 +43,8 @@ def RunGitCommand(directory, command): ...@@ -42,7 +43,8 @@ def RunGitCommand(directory, command):
cwd=directory, cwd=directory,
shell=(sys.platform=='win32')) shell=(sys.platform=='win32'))
return proc return proc
except OSError: except OSError as e:
logging.error('Command %r failed: %s' % (' '.join(command), e))
return None return None
...@@ -174,6 +176,8 @@ def main(argv=None): ...@@ -174,6 +176,8 @@ def main(argv=None):
default='^Change-Id:') default='^Change-Id:')
opts, args = parser.parse_args(argv[1:]) opts, args = parser.parse_args(argv[1:])
logging.basicConfig(level=logging.WARNING)
out_file = opts.output out_file = opts.output
header = opts.header header = opts.header
filter=opts.filter filter=opts.filter
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment