Disable the Linux "Turn On" (install) button when the installer view is showing.

Bug: 988981
Change-Id: I8649038c3d77fad3e9daa2be5273dbf50bd6ee82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768612Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691919}

chrome/browser/resources/settings/crostini_page/crostini_page.html

@@ -43,7 +43,7 @@
           <template is="dom-if" if="[[!prefs.crostini.enabled.value]]">
             <div class="separator"></div>
             <cr-button id="enable"
-                disabled="[[!allowCrostini]]"
+                disabled$="[[disableCrostiniInstall_]]"
                 on-click="onEnableTap_"
                 aria-label="$i18n{crostiniPageTitle}"
                 aria-describedby="secondaryText">

chrome/browser/resources/settings/crostini_page/crostini_page.js

@@ -12,7 +12,7 @@
 Polymer({
   is: 'settings-crostini-page',
 
-  behaviors: [I18nBehavior, PrefsBehavior],
+  behaviors: [I18nBehavior, PrefsBehavior, WebUIListenerBehavior],
 
   properties: {
     /** Preferences state. */
@@ -49,6 +49,27 @@ Polymer({
         return map;
       },
     },
+
+    /**
+     * Whether the install option should be enabled.
+     * @private {boolean}
+     */
+    disableCrostiniInstall_: {
+      type: Boolean,
+    },
+  },
+
+  attached: function() {
+    if (!loadTimeData.getBoolean('allowCrostini')) {
+      this.disableCrostiniInstall_ = true;
+      return;
+    }
+    this.addWebUIListener(
+        'crostini-installer-status-changed', (installerShowing) => {
+          this.disableCrostiniInstall_ = installerShowing;
+        });
+    settings.CrostiniBrowserProxyImpl.getInstance()
+        .requestCrostiniInstallerStatus();
   },
 
   /**

chrome/test/data/webui/settings/chromeos/crostini_page_test.js

@@ -51,6 +51,7 @@ suite('CrostiniPageTests', function() {
       const button = crostiniPage.$$('#enable');
       assertTrue(!!button);
       assertFalse(!!crostiniPage.$$('.subpage-arrow'));
+      assertFalse(button.disabled);
 
       button.click();
       Polymer.dom.flush();
@@ -60,6 +61,26 @@ suite('CrostiniPageTests', function() {
 
       assertTrue(!!crostiniPage.$$('.subpage-arrow'));
     });
+
+    test('ButtonDisabledDuringInstall', function() {
+      const button = crostiniPage.$$('#enable');
+      assertTrue(!!button);
+      return flushAsync()
+          .then(() => {
+            assertFalse(button.disabled);
+            cr.webUIListenerCallback('crostini-installer-status-changed', true);
+            flushAsync();
+          })
+          .then(() => {
+            assertTrue(button.disabled);
+            cr.webUIListenerCallback(
+                'crostini-installer-status-changed', false);
+            flushAsync();
+          })
+          .then(() => {
+            assertFalse(button.disabled);
+          });
+    });
   });
 
   suite('SubPageDetails', function() {

chrome/test/data/webui/settings/chromeos/os_settings_browsertest.js

@@ -225,8 +225,7 @@ var OSSettingsCrostiniPageTest = class extends OSSettingsBrowserTest {
   }
 };
 
-// TODO(crbug.com/962114): Disabled due to flakes on linux-chromeos-rel.
-TEST_F('OSSettingsCrostiniPageTest', 'DISABLED_AllJsTests', () => {
+TEST_F('OSSettingsCrostiniPageTest', 'All', () => {
   mocha.run();
 });