Commit 21b3c782 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Passwords] No outdated passwords when migration to the account store

This CL is simply removing a TODO from the corner cases to handle
for moving credentials to the account store.

The TODO was about credentials with outdated passwords. The migration
flow will kick on upon successful sign in where no other bubble is shown

i.e. it cannot be a save or update bubble. This entails there is an
up to date password in the underlying stores. In this TODO there is only
credentials, and hence it must be up to date.

Bug: 1032992
Change-Id: I9c2bdaa1868b309e96c9591eb7cb1db1c7de3517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087224
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747278}
parent c535f877
......@@ -136,13 +136,11 @@ bool MultiStorePasswordSaveManager::IsAccountStoreEnabled() {
void MultiStorePasswordSaveManager::MoveCredentialsToAccountStore() {
// TODO(crbug.com/1032992): There are other rare corner cases that should
// still be handled:
// 1. Credential exists only in the profile store but with an outdated
// password.
// 2. Credentials exist in both stores.
// 3. Credentials exist in both stores while one of them of outdated. (profile
// or remote).
// 4. Credential exists only in the profile store but a PSL matched one exists
// 1. Credentials exist in both stores.
// 2. Credential exists only in the profile store but a PSL matched one exists
// in both profile and account store.
// 3. Moving credentials upon an update. FormFetch will have an outdated
// credentials. Fix it if this turns out to be a product requirement.
const std::vector<const PasswordForm*> account_store_matches =
AccountStoreMatches(form_fetcher_->GetBestMatches());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment