[Extensions] Remove inIncognitoTab handling for manifest v1

Manifest v1 had an "inIncognitoTab" on the chrome.extension API object
property instead of the new "inIncognitoContext". Remove support for
this fully (and update a stale reference).

Bug: 816677

Change-Id: I4cefe0359ff3c4cae0df06b467c5628f6cd27fc6
Reviewed-on: https://chromium-review.googlesource.com/973542Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545627}

chrome/test/data/extensions/api_test/incognito/apis/background.js

@@ -86,7 +86,8 @@ chrome.test.getConfig(function(config) {
       var testUrl = "http://localhost:PORT/extensions/test_file.html"
           .replace(/PORT/, config.testServer.port);
 
-      // Test that chrome.extension.inIncognitoTab is true for incognito tabs.
+      // Test that chrome.extension.inIncognitoContext is true for incognito
+      // tabs.
       chrome.tabs.create({windowId: incognitoWindow.id, url: testUrl},
         pass(function(tab) {
           chrome.tabs.executeScript(tab.id,

extensions/renderer/resources/extension_custom_bindings.js

@@ -14,7 +14,6 @@ var chrome = requireNative('chrome').GetChrome();
 var inIncognitoContext = requireNative('process').InIncognitoContext();
 var sendRequestIsDisabled = requireNative('process').IsSendRequestDisabled();
 var contextType = requireNative('process').GetContextType();
-var manifestVersion = requireNative('process').GetManifestVersion();
 
 // This should match chrome.windows.WINDOW_ID_NONE.
 //
@@ -26,10 +25,6 @@ var TAB_ID_NONE = -1;
 
 binding.registerCustomHook(function(bindingsAPI, extensionId) {
   var extension = bindingsAPI.compiledApi;
-  if (manifestVersion < 2) {
-    chrome.self = extension;
-    extension.inIncognitoTab = inIncognitoContext;
-  }
   extension.inIncognitoContext = inIncognitoContext;
 
   var apiFunctions = bindingsAPI.apiFunctions;