Commit 21bb06bb authored by sky@chromium.org's avatar sky@chromium.org

Fixes leak in ViewManagerConnection

Nodes weren't being properly deleted when ViewManagerConnection was
deleted.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/309793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274448 0039d316-1c4b-4281-b951-d872f2087c98
parent 6ac6e8d1
......@@ -58,11 +58,11 @@ ViewManagerConnection::~ViewManagerConnection() {
this, root_node_manager_,
RootNodeManager::CHANGE_TYPE_ADVANCE_SERVER_CHANGE_ID, true);
while (!node_map_.empty()) {
Node* node = node_map_.begin()->second;
scoped_ptr<Node> node(node_map_.begin()->second);
Node* parent = node->GetParent();
const NodeId node_id(node->id());
if (parent)
parent->Remove(node);
parent->Remove(node.get());
root_node_manager_->ProcessNodeDeleted(node_id);
node_map_.erase(NodeIdToTransportId(node_id));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment