Fix flakey test_server.
See: https://bugs.chromium.org/p/chromium/issues/detail?id=946475#c48 I believe the root cause of the flake is trying to test if the server has been killed by trying to rebind to the port, although my test shows that the port can get claimed for something else by the system. Add a process.wait() to ensure server process has terminated and remove the error from checking the port status. Could do a check on PID status but system could reassign the PID, so that could lead to the same flake as before except based on PID instead of port number. Bug: 946475 Change-Id: I48911fffcab6b592ddf627e5999fc0609e0f0b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339553Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#799803}
Showing
Please register or sign in to comment