Commit 21dc495f authored by Frédéric Wang's avatar Frédéric Wang Committed by Commit Bot

Migrate DeprecatedEqual to EqualASCII for DOM events and database authorizer

This migrates remaining DeprecatedEqual comparisons against ASCII
constants [1]. Although it is potentially web-facing, no tests are
written as suggested on blink-dev [2].

[1] https://docs.google.com/document/d/1uZ0wMBF63eLJNbW3yz1oGK7qkO3VqRUwdmNAbiLanN8
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ

Bug: 627682
Change-Id: I5479c236c44c61a4f722a1746fdc859983c3135b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128315Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#757108}
parent 1527cb7a
......@@ -17,7 +17,7 @@ namespace blink {
Event* Event{{suffix}}Factory::Create(ExecutionContext* executionContext, const String& type) {
{% for event in events %}
if (DeprecatedEqualIgnoringCase(type, "{{event|name}}"){% if event.RuntimeEnabled %} && RuntimeEnabledFeatures::{{event.RuntimeEnabled}}(){% endif %}) {
if (EqualIgnoringASCIICase(type, "{{event|name}}"){% if event.RuntimeEnabled %} && RuntimeEnabledFeatures::{{event.RuntimeEnabled}}(){% endif %}) {
{% if not event|name|create_event_ignore_case_list %}
UseCounter::Count(executionContext, WebFeature::k{{event|name|measure_name}});
{% endif %}
......
......@@ -242,7 +242,7 @@ int DatabaseAuthorizer::CreateVTable(const String& table_name,
return kSQLAuthDeny;
// Allow only the FTS3 extension
if (!DeprecatedEqualIgnoringCase(module_name, "fts3"))
if (!EqualIgnoringASCIICase(module_name, "fts3"))
return kSQLAuthDeny;
last_action_changed_database_ = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment