Set CFBundleName for SxS Chromes

In the past, this wasn't done for Canary because the idea was for
it to be as identical to the normal Chrome Stable as possible. Now
that we're making Chromes to run side-by-side to Chrome Stable,
they need their own identity lest visual issues like the one in
the linked bug appear.

Bug: 1109411
Change-Id: Ie3c75014f5dabfe61d5925383dac5f07b2fce481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318726
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792241}

chrome/installer/mac/signing/modification.py

@@ -14,6 +14,7 @@ from . import commands, parts
 
 _CF_BUNDLE_EXE = 'CFBundleExecutable'
 _CF_BUNDLE_ID = 'CFBundleIdentifier'
+_CF_BUNDLE_NAME = 'CFBundleName'
 _ENT_APP_ID = 'com.apple.application-identifier'
 _KS_BRAND_ID = 'KSBrandID'
 _KS_CHANNEL_ID = 'KSChannelID'
@@ -48,6 +49,7 @@ def _modify_plists(paths, dist, config):
 
             app_plist[_CF_BUNDLE_ID] = config.base_bundle_id
             app_plist[_CF_BUNDLE_EXE] = config.app_product
+            app_plist[_CF_BUNDLE_NAME] = config.app_product
             app_plist[_KS_PRODUCT_ID] += '.' + dist.channel
 
         # Apply the channel and brand code changes.

chrome/installer/mac/signing/modification_test.py

@@ -339,6 +339,7 @@ class TestModification(unittest.TestCase):
                 {
                     'CFBundleIdentifier': config.base_bundle_id,
                     'CFBundleExecutable': config.app_product,
+                    'CFBundleName': config.app_product,
                     'KSProductID': 'test.ksproduct.canary',
                     'KSChannelID': 'canary',
                     'KSChannelID-full': 'canary-full',