[LayoutNG] Rebaseline fast/writing-mode/border-image-vertical-lr.html

fast/writing-mode/border-image-vertical-lr.html produces different results because, in legacy, block direction borders applied to inline boxes affect positioning of the line box in vertical-lr writing-mode, when they should not. This patch rebaselines it, and also adds a minimized test to check such borders do not affect line box positioning. Gecko, and WebKit fail the test. Edge passes this test, though it paints the border at the incorrect position. Testing the border positoin is not ref-testable and that it is not included. Bug: 636993 Change-Id: I2568d19dac7f7ea886a46d45620bc22feb172c53 Reviewed-on: https://chromium-review.googlesource.com/c/1301698Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603051}

[LayoutNG] Rebaseline fast/writing-mode/border-image-vertical-lr.html
fast/writing-mode/border-image-vertical-lr.html produces different results because, in legacy, block direction borders applied to inline boxes affect positioning of the line box in vertical-lr writing-mode, when they should not. This patch rebaselines it, and also adds a minimized test to check such borders do not affect line box positioning. Gecko, and WebKit fail the test. Edge passes this test, though it paints the border at the incorrect position. Testing the border positoin is not ref-testable and that it is not included. Bug: 636993 Change-Id: I2568d19dac7f7ea886a46d45620bc22feb172c53 Reviewed-on: https://chromium-review.googlesource.com/c/1301698Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603051}
221ff95e · Koji Ishii · Commit Bot · fd3f5520 · 221ff95e · 221ff95e
Commit 221ff95e authored Oct 26, 2018 by Koji Ishii Committed by Commit Bot Oct 26, 2018
5 changed files
--- a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
+++ b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
@@ -183,6 +183,7 @@ crbug.com/591099 external/wpt/css/css-writing-modes/available-size-012.html [ Fa
 crbug.com/591099 external/wpt/css/css-writing-modes/available-size-017.html [ Pass ]
 crbug.com/591099 external/wpt/css/css-writing-modes/available-size-018.html [ Failure ]
 crbug.com/591099 external/wpt/css/css-writing-modes/block-flow-direction-vrl-009.xht [ Pass ]
+crbug.com/591099 external/wpt/css/css-writing-modes/inline-box-border-vlr-001.html [ Pass ]
 crbug.com/591099 external/wpt/css/css-writing-modes/line-box-direction-vrl-009.xht [ Pass ]
 crbug.com/591099 external/wpt/css/css-writing-modes/line-box-height-vlr-021.xht [ Pass ]
 crbug.com/591099 external/wpt/css/css-writing-modes/line-box-height-vlr-023.xht [ Pass ]
@@ -313,7 +314,6 @@ crbug.com/591099 fast/text/whitespace/018.html [ Failure ]
 crbug.com/591099 fast/writing-mode/auto-sizing-orthogonal-flows.html [ Failure ]
 crbug.com/714962 fast/writing-mode/background-vertical-lr.html [ Failure ]
 crbug.com/591099 fast/writing-mode/basic-vertical-line.html [ Failure ]
-crbug.com/591099 fast/writing-mode/border-image-vertical-lr.html [ Failure ]
 crbug.com/591099 fast/writing-mode/border-radius-clipping-vertical-lr.html [ Failure ]
 crbug.com/714962 fast/writing-mode/border-styles-vertical-lr.html [ Failure ]
 crbug.com/591099 fast/writing-mode/fieldsets.html [ Failure ]

--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -440,6 +440,7 @@ crbug.com/591099 external/wpt/css/css-sizing/intrinsic-percent-non-replaced-005.
 crbug.com/591099 external/wpt/css/cssom-view/elementsFromPoint-inline-vrl-ltr.html [ Failure ]
 crbug.com/591099 external/wpt/css/cssom-view/elementsFromPoint-inline-vrl-rtl.html [ Failure ]
 crbug.com/591099 external/wpt/css/cssom-view/offsetTopLeftInline.html [ Failure ]
+crbug.com/591099 external/wpt/css/css-writing-modes/inline-box-border-vlr-001.html [ Failure ]
 crbug.com/591099 tables/mozilla/bugs/bug14159-1.html [ Failure ]

 ### virtual/layout_ng/external/wpt/css/CSS2/floats

--- a/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-box-border-vlr-001.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-box-border-vlr-001.html
+<!DOCTYPE html>
+<link rel="author" href="kojii@chromium.org">
+<link rel="help" href="https://drafts.csswg.org/css-writing-modes-3/#block-flow" title="3.1 Block Flow Direction: the writing-mode property">
+<link rel="match" href="reference/inline-box-border-vlr-001.html">
+<meta content="This test checks that block direciton borders applied to inline boxes do not affect the height of the line box, in vertical-lr writing-mode. The border is set to transparent to make this a ref-test.">
+<style>
+html {
+  margin: 0;
+  font-size: 20px;
+}
+body {
+  margin: 1em;
+  border: 1px solid blue;
+}
+body > div {
+  margin-bottom: 2em;
+  border: 1px solid black;
+}
+</style>
+<body>
+  <div style="writing-mode: vertical-lr; height: 1em">
+    <div><span>a</span></div>
+  </div>
+  <div style="writing-mode: vertical-lr; height: 1em">
+    <div><span style="border-left: 20px solid transparent">a</span></div>
+  </div>
+</body>
--- a/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/reference/inline-box-border-vlr-001.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/reference/inline-box-border-vlr-001.html
+<!DOCTYPE html>
+<style>
+html {
+  margin: 0;
+  font-size: 20px;
+}
+body {
+  margin: 1em;
+  border: 1px solid blue;
+}
+body > div {
+  margin-bottom: 2em;
+  border: 1px solid black;
+}
+</style>
+<body>
+  <div style="writing-mode: vertical-lr; height: 1em">
+    <div><span>a</span></div>
+  </div>
+  <div style="writing-mode: vertical-lr; height: 1em">
+    <div><span>a</span></div>
+  </div>
+</body>
--- a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/writing-mode/border-image-vertical-lr-expected.png
+++ b/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/writing-mode/border-image-vertical-lr-expected.png