Extirpate CreateBooleanValue.

BUG=160586

Review URL: https://codereview.chromium.org/399433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283619 0039d316-1c4b-4281-b951-d872f2087c98

cc/layers/nine_patch_layer_impl.cc

@@ -399,9 +399,7 @@ base::DictionaryValue* NinePatchLayerImpl::LayerTreeAsJson() const {
 
   result->Set("Border", MathUtil::AsValue(border_).release());
 
-  base::FundamentalValue* fill_center =
-      base::Value::CreateBooleanValue(fill_center_);
-  result->Set("FillCenter", fill_center);
+  result->SetBoolean("FillCenter", fill_center_);
 
   return result;
 }

components/policy/core/browser/autofill_policy_handler.cc

@@ -23,10 +23,8 @@ void AutofillPolicyHandler::ApplyPolicySettings(const PolicyMap& policies,
                                                 PrefValueMap* prefs) {
   const base::Value* value = policies.GetValue(policy_name());
   bool auto_fill_enabled;
-  if (value && value->GetAsBoolean(&auto_fill_enabled) && !auto_fill_enabled) {
-    prefs->SetValue(autofill::prefs::kAutofillEnabled,
-                    base::Value::CreateBooleanValue(false));
-  }
+  if (value && value->GetAsBoolean(&auto_fill_enabled) && !auto_fill_enabled)
+    prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false);
 }
 
 }  // namespace policy

components/policy/core/common/mac_util.cc

@@ -48,8 +48,8 @@ scoped_ptr<base::Value> PropertyToValue(CFPropertyListRef property) {
     return scoped_ptr<base::Value>(base::Value::CreateNullValue());
 
   if (CFBooleanRef boolean = CFCast<CFBooleanRef>(property)) {
-    return scoped_ptr<base::Value>(
-        base::Value::CreateBooleanValue(CFBooleanGetValue(boolean)));
+    return scoped_ptr<base::Value>(new base::FundamentalValue(
+        static_cast<bool>(CFBooleanGetValue(boolean))));
   }
 
   if (CFNumberRef number = CFCast<CFNumberRef>(property)) {

components/policy/core/common/registry_dict_win.cc

@@ -71,7 +71,7 @@ scoped_ptr<base::Value> ConvertValue(const base::Value& value,
           (value.GetAsString(&string_value) &&
            base::StringToInt(string_value, &int_value))) {
         return scoped_ptr<base::Value>(
-            base::Value::CreateBooleanValue(int_value != 0));
+            new base::FundamentalValue(int_value != 0));
       }
       break;
     }

components/policy/tools/generate_policy_source.py

@@ -856,7 +856,7 @@ CPP_FOOT = '''}
 
 def _CreateValue(type, arg):
   if type == 'TYPE_BOOLEAN':
-    return 'base::Value::CreateBooleanValue(%s)' % arg
+    return 'new base::FundamentalValue(%s)' % arg
   elif type == 'TYPE_INTEGER':
     return 'DecodeIntegerValue(%s)' % arg
   elif type == 'TYPE_STRING':

components/pref_registry/pref_registry_syncable.cc

@@ -25,9 +25,9 @@ base::Value* CreateLocaleDefaultValue(base::Value::Type type,
   switch (type) {
     case base::Value::TYPE_BOOLEAN: {
       if ("true" == resource_string)
-        return base::Value::CreateBooleanValue(true);
+        return new base::FundamentalValue(true);
       if ("false" == resource_string)
-        return base::Value::CreateBooleanValue(false);
+        return new base::FundamentalValue(false);
       break;
     }
 
@@ -77,9 +77,8 @@ void PrefRegistrySyncable::SetSyncableRegistrationCallback(
 void PrefRegistrySyncable::RegisterBooleanPref(const char* path,
                                                bool default_value,
                                                PrefSyncStatus sync_status) {
-  RegisterSyncablePreference(path,
-                             base::Value::CreateBooleanValue(default_value),
-                             sync_status);
+  RegisterSyncablePreference(
+      path, new base::FundamentalValue(default_value), sync_status);
 }
 
 void PrefRegistrySyncable::RegisterIntegerPref(const char* path,

extensions/browser/extension_prefs.cc

@@ -720,8 +720,9 @@ bool ExtensionPrefs::HasWipeoutBeenAcknowledged(
 void ExtensionPrefs::SetWipeoutAcknowledged(
     const std::string& extension_id,
     bool value) {
-  UpdateExtensionPref(extension_id, kPrefWipeoutAcknowledged,
-                      value ? base::Value::CreateBooleanValue(value) : NULL);
+  UpdateExtensionPref(extension_id,
+                      kPrefWipeoutAcknowledged,
+                      value ? new base::FundamentalValue(value) : NULL);
 }
 
 bool ExtensionPrefs::HasSettingsApiBubbleBeenAcknowledged(
@@ -735,7 +736,7 @@ void ExtensionPrefs::SetSettingsApiBubbleBeenAcknowledged(
     bool value) {
   UpdateExtensionPref(extension_id,
                       kPrefSettingsBubbleAcknowledged,
-                      value ? base::Value::CreateBooleanValue(value) : NULL);
+                      value ? new base::FundamentalValue(value) : NULL);
 }
 
 bool ExtensionPrefs::HasNtpOverriddenBubbleBeenAcknowledged(
@@ -748,7 +749,7 @@ void ExtensionPrefs::SetNtpOverriddenBubbleBeenAcknowledged(
     bool value) {
   UpdateExtensionPref(extension_id,
                       kPrefNtpBubbleAcknowledged,
-                      value ? base::Value::CreateBooleanValue(value) : NULL);
+                      value ? new base::FundamentalValue(value) : NULL);
 }
 
 bool ExtensionPrefs::HasProxyOverriddenBubbleBeenAcknowledged(
@@ -761,7 +762,7 @@ void ExtensionPrefs::SetProxyOverriddenBubbleBeenAcknowledged(
     bool value) {
   UpdateExtensionPref(extension_id,
                       kPrefProxyBubbleAcknowledged,
-                      value ? base::Value::CreateBooleanValue(value) : NULL);
+                      value ? new base::FundamentalValue(value) : NULL);
 }
 
 bool ExtensionPrefs::SetAlertSystemFirstRun() {