Commit 2233a90a authored by googleo's avatar googleo Committed by Commit bot

Fix some UI bugs.

1, Fix hard code always translate value and show correct "always translate" state in the same session.
2, Refresh langauge list every time, in case use changed source/target language.
3, Fix menu button desc under talkback mode.

Tested on my local N5.

BUG=703887

Review-Url: https://codereview.chromium.org/2858013003
Cr-Commit-Position: refs/heads/master@{#469573}
parent 2e20b010
......@@ -3,7 +3,6 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<!-- TODO(googleo): Add correct style based on spec and contentDescription. -->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/translate_infobar_content"
......@@ -32,7 +31,7 @@
android:minWidth="@dimen/min_touch_target_size"
android:scaleType="center"
android:background="?attr/selectableItemBackground"
android:contentDescription="@null"
android:contentDescription="@string/accessibility_toolbar_btn_menu"
android:src="@drawable/btn_menu"
app:tint="@color/dark_mode_tint" />
</LinearLayout>
......@@ -178,9 +178,14 @@ class TranslateCompactInfoBar extends InfoBar
mLanguageMenuHelper.show(TranslateMenu.MENU_TARGET_LANGUAGE);
return;
case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.ALWAYS_TRANSLATE, true);
showSnackbar(TranslateSnackbarType.ALWAYS_TRANSLATE);
mOptions.toggleAlwaysTranslateLanguageState(
!mOptions.alwaysTranslateLanguageState());
nativeApplyBoolTranslateOption(mNativeTranslateInfoBarPtr,
TranslateOption.ALWAYS_TRANSLATE, mOptions.alwaysTranslateLanguageState());
// Only show snackbar when "Always Translate" is enabled.
if (mOptions.alwaysTranslateLanguageState()) {
showSnackbar(TranslateSnackbarType.ALWAYS_TRANSLATE);
}
return;
case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
nativeApplyBoolTranslateOption(
......
......@@ -214,8 +214,8 @@ public class TranslateMenuHelper implements AdapterView.OnItemClickListener {
}
private void refreshMenu(int menuType) {
// Don't refresh if the type is same as previous.
if (menuType == mMenuType) return;
// MENU_OVERFLOW is static and it should not reload.
if (menuType == TranslateMenu.MENU_OVERFLOW) return;
clear();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment