Commit 2260adad authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Provide simple string to ResourceFetcher::requestResource trace

Currently the url argument for the trace event is {url: <url>}, but
that prevents us to search for the url from the UI. Provide a simple
string to the argument to make it work.

Bug: 937173
Change-Id: Ic4a344b52a0967018d3955b9909f967d655357c6
Reviewed-on: https://chromium-review.googlesource.com/c/1496119
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: default avatarTaiju Tsuiki <tzik@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636758}
parent 193ae6e7
...@@ -254,12 +254,6 @@ bool MatchesStaleWhileRevalidateAllowList(const String& host) { ...@@ -254,12 +254,6 @@ bool MatchesStaleWhileRevalidateAllowList(const String& host) {
stale_while_revalidate_allow_hosts->Find(host) != kNotFound; stale_while_revalidate_allow_hosts->Find(host) != kNotFound;
} }
std::unique_ptr<TracedValue> UrlForTraceEvent(const KURL& url) {
std::unique_ptr<TracedValue> value = TracedValue::Create();
value->SetString("url", url.GetString());
return value;
}
std::unique_ptr<TracedValue> BeginResourceLoadData( std::unique_ptr<TracedValue> BeginResourceLoadData(
const blink::ResourceRequest& request) { const blink::ResourceRequest& request) {
std::unique_ptr<TracedValue> value = TracedValue::Create(); std::unique_ptr<TracedValue> value = TracedValue::Create();
...@@ -899,7 +893,7 @@ Resource* ResourceFetcher::RequestResource(FetchParameters& params, ...@@ -899,7 +893,7 @@ Resource* ResourceFetcher::RequestResource(FetchParameters& params,
SCOPED_BLINK_UMA_HISTOGRAM_TIMER_THREAD_SAFE( SCOPED_BLINK_UMA_HISTOGRAM_TIMER_THREAD_SAFE(
"Blink.Fetch.RequestResourceTime"); "Blink.Fetch.RequestResourceTime");
TRACE_EVENT1("blink", "ResourceFetcher::requestResource", "url", TRACE_EVENT1("blink", "ResourceFetcher::requestResource", "url",
UrlForTraceEvent(params.Url())); params.Url().GetString().Utf8());
// TODO(crbug.com/123004): Remove once we have enough stats on data URIs that // TODO(crbug.com/123004): Remove once we have enough stats on data URIs that
// contain fragments ('#' characters). // contain fragments ('#' characters).
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment