Commit 2260e927 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Passwords] Remove PasswordAutofillAgent::OnProbablyFormSubmitted

At the moment, provisionally saved password form is processed in
browser process in the method PasswordManager::DidNavigateMainFrame().
No need to process the same event in the renderer as well.


Change-Id: I08f183c62483cf3ea7bfae98f0642bbf275af9eb
Bug: 949519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821557
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: default avatarVadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699345}
parent 0ea248ac
...@@ -1362,34 +1362,7 @@ void PasswordAutofillAgent::ReadyToCommitNavigation( ...@@ -1362,34 +1362,7 @@ void PasswordAutofillAgent::ReadyToCommitNavigation(
CleanupOnDocumentShutdown(); CleanupOnDocumentShutdown();
} }
void PasswordAutofillAgent::OnProbablyFormSubmitted() { void PasswordAutofillAgent::OnProbablyFormSubmitted() {}
std::unique_ptr<RendererSavePasswordProgressLogger> logger;
if (logging_state_active_) {
logger.reset(new RendererSavePasswordProgressLogger(
GetPasswordManagerDriver().get()));
logger->LogMessage(Logger::STRING_DID_START_PROVISIONAL_LOAD_METHOD);
}
if (!FrameCanAccessPasswordManager()) {
if (logger)
logger->LogMessage(Logger::STRING_SECURITY_ORIGIN_FAILURE);
return;
}
// If onsubmit has been called, try and save that form.
if (provisionally_saved_form_.IsSet()) {
if (logger) {
logger->LogPasswordForm(Logger::STRING_PROVISIONALLY_SAVED_FORM_FOR_FRAME,
provisionally_saved_form_.password_form());
}
provisionally_saved_form_.SetSubmissionIndicatorEvent(
SubmissionIndicatorEvent::
PROVISIONALLY_SAVED_FORM_ON_START_PROVISIONAL_LOAD);
GetPasswordManagerDriver()->PasswordFormSubmitted(
provisionally_saved_form_.password_form());
provisionally_saved_form_.Reset();
}
}
// mojom::PasswordAutofillAgent: // mojom::PasswordAutofillAgent:
void PasswordAutofillAgent::FillPasswordForm( void PasswordAutofillAgent::FillPasswordForm(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment