[Controls Refresh] Regression: Focus is not seen on color selector icon when...

[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key. This change addresses the bug in which the color picker selection ring gets placed in the top left corner after closing a color picker with (255,255,255) is selected. Bug: 1046648 Change-Id: Idb82a962c0ba40338c4a38c5c5526dea7339c5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032420Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737900}

[Controls Refresh] Regression: Focus is not seen on color selector icon when...
[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key. This change addresses the bug in which the color picker selection ring gets placed in the top left corner after closing a color picker with (255,255,255) is selected. Bug: 1046648 Change-Id: Idb82a962c0ba40338c4a38c5c5526dea7339c5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032420Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737900}
2292ef33 · Sam Sebree · Commit Bot · eb7c2571 · 2292ef33 · 2292ef33
Commit 2292ef33 authored Feb 03, 2020 by Sam Sebree Committed by Commit Bot Feb 03, 2020
5 changed files
--- a/third_party/blink/renderer/core/html/forms/resources/color_picker.js
+++ b/third_party/blink/renderer/core/html/forms/resources/color_picker.js
@@ -1014,6 +1014,7 @@ class ColorSelectionRing extends HTMLElement {

  initialize() {
    this.set(this.backingColorPalette_.left, this.backingColorPalette_.top);
+    this.onPositionChange_();
  }

  /**

--- a/third_party/blink/web_tests/platform/linux/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen-expected.png
+++ b/third_party/blink/web_tests/platform/linux/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen-expected.png
--- a/third_party/blink/web_tests/platform/mac/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen-expected.png
+++ b/third_party/blink/web_tests/platform/mac/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen-expected.png
--- a/third_party/blink/web_tests/platform/win/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen-expected.png
+++ b/third_party/blink/web_tests/platform/win/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen-expected.png
--- a/third_party/blink/web_tests/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen.html
+++ b/third_party/blink/web_tests/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen.html
+<!DOCTYPE html>
+<html>
+
+<head>
+    <script>
+        testRunner.waitUntilDone();
+    </script>
+    <script src='../../../fast/forms/resources/picker-common.js'></script>
+</head>
+
+<body>
+    <input type='color' id='color' value='#FFFFFF'>
+
+    <p id='description' style='opacity: 0'></p>
+    <div id='console' style='opacity: 0'></div>
+
+    <script>
+        openPickerWithPromise(document.getElementById('color')).then(() => {
+            eventSender.keyDown('Enter');
+            openPicker(document.getElementById('color'),
+                () => testRunner.notifyDone(),
+                () => testRunner.notifyDone());
+        })
+    </script>
+</body>
+
+</html>
\ No newline at end of file