Fix BlockPopupsAppInterface stubbing for EG2.

Add semi colon to avoid breaking Xcode indexing.

Bug: 1015113
Change-Id: I9dff5b679b24267e3edc0ac83ce5f52a294ded9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972938
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725973}

ios/chrome/browser/ui/settings/block_popups_egtest.mm

@@ -25,7 +25,12 @@
 #endif
 
 #if defined(CHROME_EARL_GREY_2)
-GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(BlockPopupsAppInterface)
+// TODO(crbug.com/1015113): The EG2 macro is breaking indexing for some reason
+// without the trailing semicolon.  For now, disable the extra semi warning
+// so Xcode indexing works for the egtest.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wc++98-compat-extra-semi"
+GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(BlockPopupsAppInterface);
 #endif  // defined(CHROME_EARL_GREY_2)
 
 using chrome_test_util::ContentSettingsButton;