Include-what-you-use related to logging.h (ios)

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Id378f4f3ceaabbfeabb83a02779708f5707c4fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248762
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779330}

ios/chrome/app/startup/ios_chrome_main_delegate.mm

@@ -4,6 +4,7 @@
 
 #include "ios/chrome/app/startup/ios_chrome_main_delegate.h"
 
+#include "base/logging.h"
 #include "components/component_updater/component_updater_paths.h"
 #include "ios/chrome/browser/chrome_paths.h"
 #include "third_party/skia/include/core/SkGraphics.h"

ios/chrome/browser/autofill/form_input_accessory_view_handler.mm

@@ -8,6 +8,7 @@
 
 #include "base/mac/foundation_util.h"
 #include "base/metrics/histogram_macros.h"
+#include "base/notreached.h"
 #import "components/autofill/core/browser/keyboard_accessory_metrics_logger.h"
 #import "components/autofill/ios/browser/js_suggestion_manager.h"
 #import "ios/chrome/browser/ui/util/uikit_ui_util.h"

ios/chrome/browser/infobars/infobar_badge_model.mm

@@ -4,7 +4,7 @@
 
 #import "ios/chrome/browser/infobars/infobar_badge_model.h"
 
-#import "base/logging.h"
+#import "base/check_op.h"
 #include "ios/chrome/browser/ui/badges/badge_type_util.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)

ios/chrome/browser/metrics/first_user_action_recorder.cc

@@ -6,6 +6,7 @@
 
 #include "base/bind.h"
 #include "base/location.h"
+#include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"

ios/chrome/browser/notification_promo.cc

@@ -8,6 +8,8 @@
 
 #include <utility>
 
+#include "base/check.h"
+#include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"

ios/chrome/browser/ui/authentication/signin/signin_coordinator.mm

@@ -4,6 +4,7 @@
 
 #import "ios/chrome/browser/ui/authentication/signin/signin_coordinator.h"
 
+#include "base/notreached.h"
 #import "ios/chrome/browser/ui/authentication/signin/add_account_signin/add_account_signin_coordinator.h"
 #import "ios/chrome/browser/ui/authentication/signin/advanced_settings_signin/advanced_settings_signin_coordinator.h"
 #import "ios/chrome/browser/ui/authentication/signin/trusted_vault_reauthentication/trusted_vault_reauthentication_coordinator.h"

ios/chrome/browser/ui/badges/badge_button.mm

@@ -5,7 +5,7 @@
 #import "ios/chrome/browser/ui/badges/badge_button.h"
 
 #include "base/feature_list.h"
-#import "base/logging.h"
+#import "base/notreached.h"
 #import "ios/chrome/browser/ui/badges/badge_constants.h"
 #include "ios/chrome/browser/ui/ui_feature_flags.h"
 #import "ios/chrome/browser/ui/util/uikit_ui_util.h"

ios/chrome/browser/ui/badges/badge_button_factory.mm

@@ -4,7 +4,9 @@
 
 #import "ios/chrome/browser/ui/badges/badge_button_factory.h"
 
-#import "base/logging.h"
+#include <ostream>
+
+#import "base/notreached.h"
 #import "ios/chrome/browser/ui/badges/badge_button.h"
 #import "ios/chrome/browser/ui/badges/badge_constants.h"
 #import "ios/chrome/browser/ui/badges/badge_delegate.h"

ios/chrome/browser/ui/badges/badge_popup_menu_item.mm

@@ -4,7 +4,9 @@
 
 #import "ios/chrome/browser/ui/badges/badge_popup_menu_item.h"
 
-#import "base/logging.h"
+#include <ostream>
+
+#import "base/notreached.h"
 #import "ios/chrome/browser/ui/list_model/list_model.h"
 #import "ios/chrome/browser/ui/table_view/chrome_table_view_styler.h"
 #import "ios/chrome/common/ui/colors/semantic_color_names.h"

ios/chrome/browser/ui/infobars/presentation/infobar_banner_transition_driver.mm

@@ -4,6 +4,7 @@
 
 #import "ios/chrome/browser/ui/infobars/presentation/infobar_banner_transition_driver.h"
 
+#include "base/check_op.h"
 #include "base/mac/foundation_util.h"
 #import "ios/chrome/browser/ui/infobars/presentation/infobar_banner_animator.h"
 #import "ios/chrome/browser/ui/infobars/presentation/infobar_banner_presentation_controller.h"

ios/chrome/browser/ui/ntp/ntp_tile_saver.mm

@@ -6,6 +6,7 @@
 
 #include "base/bind.h"
 #include "base/hash/md5.h"
+#include "base/logging.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/task/post_task.h"
 #include "base/task/thread_pool.h"

ios/chrome/browser/ui/ntp_tile_views/ntp_tile_constants.mm

@@ -4,6 +4,7 @@
 
 #import "ios/chrome/browser/ui/ntp_tile_views/ntp_tile_constants.h"
 
+#include "base/notreached.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ios/chrome/grit/ios_strings.h"

ios/chrome/browser/ui/omnibox/popup/omnibox_icon_formatter.mm

@@ -4,6 +4,7 @@
 
 #import "ios/chrome/browser/ui/omnibox/popup/omnibox_icon_formatter.h"
 
+#include "base/notreached.h"
 #import "components/omnibox/browser/autocomplete_match.h"
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #import "ios/chrome/browser/ui/ui_feature_flags.h"

ios/chrome/browser/ui/overlays/infobar_banner/translate/translate_infobar_banner_overlay_mediator.mm

@@ -4,6 +4,9 @@
 
 #import "ios/chrome/browser/ui/overlays/infobar_banner/translate/translate_infobar_banner_overlay_mediator.h"
 
+#include <ostream>
+
+#include "base/notreached.h"
 #import "ios/chrome/browser/overlays/public/infobar_banner/infobar_banner_overlay_responses.h"
 #import "ios/chrome/browser/overlays/public/infobar_banner/translate_infobar_banner_overlay_request_config.h"
 #import "ios/chrome/browser/ui/infobars/banners/infobar_banner_consumer.h"

ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm

@@ -5,6 +5,7 @@
 #import "ios/chrome/browser/ui/settings/settings_root_table_view_controller.h"
 
 #import "base/mac/foundation_util.h"
+#include "base/notreached.h"
 #import "ios/chrome/browser/ui/commands/application_commands.h"
 #import "ios/chrome/browser/ui/commands/open_new_tab_command.h"
 #import "ios/chrome/browser/ui/settings/bar_button_activity_indicator.h"

ios/chrome/browser/ui/util/core_text_util.mm

@@ -6,6 +6,7 @@
 
 #import <UIKit/UIKit.h>
 
+#include "base/check_op.h"
 #include "base/mac/foundation_util.h"
 #import "ios/chrome/browser/ui/util/manual_text_framer.h"
 #import "ios/chrome/browser/ui/util/text_frame.h"

ios/chrome/browser/ui/util/label_observer.mm

@@ -6,6 +6,7 @@
 
 #import <objc/runtime.h>
 
+#include "base/notreached.h"
 #include "base/strings/sys_string_conversions.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)

ios/chrome/browser/web_state_list/web_state_list.h

@@ -9,6 +9,7 @@
 #include <vector>
 
 #include "base/auto_reset.h"
+#include "base/callback_forward.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/observer_list.h"

ios/chrome/common/ui/reauthentication/reauthentication_module.mm

@@ -5,7 +5,7 @@
 
 #import <LocalAuthentication/LocalAuthentication.h>
 
-#import "base/logging.h"
+#include "base/check.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."

ios/chrome/credential_provider_extension/password_util.mm

@@ -4,9 +4,11 @@
 
 #import "ios/chrome/credential_provider_extension/password_util.h"
 
+#include <ostream>
+
 #import <Security/Security.h>
 
-#import "base/logging.h"
+#import "base/check.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."

ios/chrome/search_widget_extension/search_widget_view_controller.mm

@@ -5,6 +5,7 @@
 #import "ios/chrome/search_widget_extension/search_widget_view_controller.h"
 
 #include "base/mac/foundation_util.h"
+#include "base/notreached.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/open_from_clipboard/clipboard_recent_content_impl_ios.h"
 #include "ios/chrome/common/app_group/app_group_command.h"

ios/chrome/test/earl_grey/eg_tests_hook.mm

@@ -5,6 +5,7 @@
 #include "ios/chrome/app/tests_hook.h"
 
 #include "base/command_line.h"
+#include "base/logging.h"
 #include "ios/chrome/browser/policy/test_platform_policy_provider.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)

ios/components/security_interstitials/ios_blocking_page_tab_helper.mm

@@ -4,6 +4,7 @@
 
 #import "ios/components/security_interstitials/ios_blocking_page_tab_helper.h"
 
+#include "base/logging.h"
 #include "base/values.h"
 #include "ios/components/security_interstitials/ios_security_interstitial_page.h"
 #import "ios/web/public/navigation/navigation_context.h"

ios/net/cookies/system_cookie_store.mm

@@ -6,6 +6,7 @@
 
 #include <memory>
 
+#include "base/logging.h"
 #import "ios/net/cookies/cookie_creation_time_manager.h"
 #include "ios/net/ios_net_buildflags.h"
 

ios/web/download/BUILD.gn

@@ -33,6 +33,7 @@ source_set("download_cookies") {
   visibility = [ ":*" ]
 
   deps = [
+    "//base",
     "//ios/net",
     "//net",
   ]

ios/web/download/download_session_cookie_storage.mm

@@ -4,6 +4,7 @@
 
 #import "ios/web/download/download_session_cookie_storage.h"
 
+#include "base/notreached.h"
 #include "ios/net/cookies/system_cookie_util.h"
 #import "net/base/mac/url_conversions.h"
 

ios/web/download/download_task_impl.h

@@ -7,6 +7,8 @@
 
 #include <string>
 
+#include "base/callback_forward.h"
+#include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #import "ios/web/public/download/download_task.h"

ios/web/favicon/favicon_util.mm

@@ -7,6 +7,7 @@
 #include <CoreFoundation/CoreFoundation.h>
 #import <WebKit/WebKit.h>
 
+#include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"

ios/web/js_messaging/crw_js_window_id_manager.mm

@@ -4,6 +4,7 @@
 
 #import "ios/web/js_messaging/crw_js_window_id_manager.h"
 
+#include "base/notreached.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/sys_string_conversions.h"
 #include "crypto/random.h"

ios/web/js_messaging/web_frame_impl.mm

@@ -9,6 +9,7 @@
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/json/json_writer.h"
+#include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"

ios/web/js_messaging/web_view_js_utils.mm

@@ -9,6 +9,7 @@
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
+#include "base/notreached.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/values.h"
 

ios/web/navigation/crw_js_navigation_handler.mm

@@ -5,6 +5,7 @@
 #import "ios/web/navigation/crw_js_navigation_handler.h"
 
 #include "base/json/string_escape.h"
+#include "base/logging.h"
 #include "base/strings/sys_string_conversions.h"
 #include "ios/web/history_state_util.h"
 #import "ios/web/js_messaging/crw_js_injector.h"

ios/web/public/js_messaging/web_frame.h

@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/callback_forward.h"
 #include "base/macros.h"
 #include "base/supports_user_data.h"
 #include "base/time/time.h"

ios/web/public/test/web_view_interaction_test_util.mm

@@ -6,6 +6,7 @@
 
 #include "base/bind.h"
 #include "base/json/string_escape.h"
+#include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"

ios/web/security/wk_web_view_security_util.mm

@@ -5,6 +5,7 @@
 #import "ios/web/security/wk_web_view_security_util.h"
 
 #include "base/mac/scoped_cftyperef.h"
+#include "base/notreached.h"
 #include "base/strings/sys_string_conversions.h"
 #include "net/cert/x509_certificate.h"
 #include "net/cert/x509_util_ios.h"

ios/web/web_state/ui/cookie_blocking_error_logger.mm

@@ -4,6 +4,8 @@
 
 #import "ios/web/web_state/ui/cookie_blocking_error_logger.h"
 
+#include "base/check.h"
+#include "base/logging.h"
 #include "base/metrics/histogram_functions.h"
 #import "base/values.h"
 #import "ios/web/public/js_messaging/web_frame.h"

ios/web/web_state/ui/crw_wk_ui_handler.mm

@@ -4,6 +4,7 @@
 
 #import "ios/web/web_state/ui/crw_wk_ui_handler.h"
 
+#include "base/logging.h"
 #include "base/strings/sys_string_conversions.h"
 #import "ios/web/navigation/wk_navigation_action_util.h"
 #import "ios/web/navigation/wk_navigation_util.h"

ios/web/web_state/ui/js_window_error_manager.mm

@@ -4,6 +4,7 @@
 
 #import "ios/web/web_state/ui/js_window_error_manager.h"
 
+#include "base/logging.h"
 #import "base/values.h"
 #import "ios/web/public/js_messaging/web_frame.h"
 

ios/web/webui/web_ui_ios_impl.mm

@@ -7,6 +7,7 @@
 #include <stddef.h>
 
 #include "base/json/json_writer.h"
+#include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"

ios/web_view/internal/web_view_web_main_delegate.mm

@@ -4,6 +4,7 @@
 
 #import "ios/web_view/internal/web_view_web_main_delegate.h"
 
+#include "base/logging.h"
 #import "base/mac/bundle_locations.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)