Commit 22e08ddc authored by chenwilliam's avatar chenwilliam Committed by Commit Bot

DevTools: stop whats new from opening on fresh profile

BUG=713901

Review-Url: https://codereview.chromium.org/2935393002
Cr-Commit-Position: refs/heads/master@{#480268}
parent 77ddcddc
Test release note Test release note
Last release note version seen: Last release note version seen:
0 1
Dumping release note text: Dumping release note text:
Highlights from Chrome 100 update Highlights from Chrome 100 update
......
...@@ -13,3 +13,8 @@ Running: alreadySeenReleaseNote ...@@ -13,3 +13,8 @@ Running: alreadySeenReleaseNote
Last seen version: 5 Last seen version: 5
Did not show release note drawer Did not show release note drawer
Running: doNotShowReleaseNoteOnFreshProfile
Last seen version: 0
Did not show release note drawer
Release note version in setting: 5
...@@ -42,6 +42,12 @@ function test() ...@@ -42,6 +42,12 @@ function test()
testMaybeShowInDrawer(lastSeenVersion); testMaybeShowInDrawer(lastSeenVersion);
next(); next();
}, },
function doNotShowReleaseNoteOnFreshProfile(next) {
var lastSeenVersion = 0;
testMaybeShowInDrawer(lastSeenVersion);
InspectorTest.addResult(`Release note version in setting: ${Help.releaseNoteVersionSetting().get()}`);
next();
},
]); ]);
} }
</script> </script>
......
...@@ -26,6 +26,7 @@ function test() { ...@@ -26,6 +26,7 @@ function test() {
InspectorTest.addSniffer(UI.viewManager, "showView", onShowView); InspectorTest.addSniffer(UI.viewManager, "showView", onShowView);
InspectorTest.addResult("Last release note version seen:"); InspectorTest.addResult("Last release note version seen:");
Help.releaseNoteVersionSetting().set(1);
InspectorTest.addResult(Help.releaseNoteVersionSetting().get() + "\n"); InspectorTest.addResult(Help.releaseNoteVersionSetting().get() + "\n");
Help.showReleaseNoteIfNeeded(); Help.showReleaseNoteIfNeeded();
......
...@@ -33,6 +33,10 @@ Help.showReleaseNoteIfNeeded = function() { ...@@ -33,6 +33,10 @@ Help.showReleaseNoteIfNeeded = function() {
* @param {number} latestVersion * @param {number} latestVersion
*/ */
Help._showReleaseNoteIfNeeded = function(lastSeenVersion, latestVersion) { Help._showReleaseNoteIfNeeded = function(lastSeenVersion, latestVersion) {
if (!lastSeenVersion) {
Help.releaseNoteVersionSetting().set(latestVersion);
return;
}
if (lastSeenVersion >= latestVersion) if (lastSeenVersion >= latestVersion)
return; return;
Help.releaseNoteVersionSetting().set(latestVersion); Help.releaseNoteVersionSetting().set(latestVersion);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment