Commit 22f96f3f authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

cbuiv: remove StoragePressureBubble anchor rect

It's always gfx::Rect() anyway, and the bubble has an anchor view.

Bug: 1064663
Change-Id: I94cfcd1c64dbb5bbce7f9990dda75b91186aa56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144772Reviewed-by: default avatarDana Fried <dfried@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758500}
parent 80cdcf17
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/bubble_anchor_util.h"
#include "chrome/browser/ui/views/chrome_layout_provider.h" #include "chrome/browser/ui/views/chrome_layout_provider.h"
#include "chrome/browser/ui/views/frame/app_menu_button.h" #include "chrome/browser/ui/views/frame/app_menu_button.h"
#include "chrome/browser/ui/views/frame/browser_view.h" #include "chrome/browser/ui/views/frame/browser_view.h"
...@@ -57,7 +56,7 @@ void StoragePressureBubbleView::ShowBubble(const url::Origin origin) { ...@@ -57,7 +56,7 @@ void StoragePressureBubbleView::ShowBubble(const url::Origin origin) {
BrowserView::GetBrowserViewForBrowser(browser) BrowserView::GetBrowserViewForBrowser(browser)
->toolbar_button_provider() ->toolbar_button_provider()
->GetAppMenuButton(), ->GetAppMenuButton(),
gfx::Rect(), browser, std::move(origin)); browser, std::move(origin));
views::BubbleDialogDelegateView::CreateBubble(bubble)->Show(); views::BubbleDialogDelegateView::CreateBubble(bubble)->Show();
RecordBubbleHistogramValue(StoragePressureBubbleHistogramValue::kShown); RecordBubbleHistogramValue(StoragePressureBubbleHistogramValue::kShown);
...@@ -65,18 +64,12 @@ void StoragePressureBubbleView::ShowBubble(const url::Origin origin) { ...@@ -65,18 +64,12 @@ void StoragePressureBubbleView::ShowBubble(const url::Origin origin) {
StoragePressureBubbleView::StoragePressureBubbleView( StoragePressureBubbleView::StoragePressureBubbleView(
views::View* anchor_view, views::View* anchor_view,
const gfx::Rect& anchor_rect,
Browser* browser, Browser* browser,
const url::Origin origin) const url::Origin origin)
: BubbleDialogDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT), : BubbleDialogDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
browser_(browser), browser_(browser),
origin_(std::move(origin)), origin_(std::move(origin)),
ignored_(true) { ignored_(true) {
if (!anchor_view) {
SetAnchorRect(anchor_rect);
set_parent_window(
platform_util::GetViewForWindow(browser->window()->GetNativeWindow()));
}
DialogDelegate::SetButtons(ui::DIALOG_BUTTON_OK); DialogDelegate::SetButtons(ui::DIALOG_BUTTON_OK);
DialogDelegate::SetButtonLabel( DialogDelegate::SetButtonLabel(
ui::DIALOG_BUTTON_OK, ui::DIALOG_BUTTON_OK,
......
...@@ -16,7 +16,6 @@ class StoragePressureBubbleView : public views::BubbleDialogDelegateView { ...@@ -16,7 +16,6 @@ class StoragePressureBubbleView : public views::BubbleDialogDelegateView {
private: private:
StoragePressureBubbleView(views::View* anchor_view, StoragePressureBubbleView(views::View* anchor_view,
const gfx::Rect& anchor_rect,
Browser* browser, Browser* browser,
const url::Origin origin); const url::Origin origin);
~StoragePressureBubbleView() override; ~StoragePressureBubbleView() override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment