Commit 22fb8e89 authored by Sven Zheng's avatar Sven Zheng Committed by Commit Bot

[lacros] Fix lacros can't build for device with debug mode

When build lacros on device with is_debug=true, it fails with:
FAILED: libprotobuf_lite.so libprotobuf_lite.so.TOC
/b/s/w/ir/cipd_bin_packages/cpython/bin/python
"../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long)
lld.elf: error: corrupt input file: version need index 2 for
symbol __deregister_frame_info is out of bounds
>>> defined in ./libmirclient.so.9

That's because this additional deps is included. From
https://codereview.chromium.org/2885223002,
the mir project has been cancelled. So it's safe to remove the deps.

For lacros, we have gn arg use_gtk=false, so mirclient will
not be in deps.

Bug: 1127103
Change-Id: Icf88d8c9a862b45e2d87818723dd700853027fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405743Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Reviewed-by: default avatarLeonard Grey <lgrey@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806358}
parent 7dae36a2
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//build/config/linux/gtk/gtk.gni")
import("//build/config/sanitizers/sanitizers.gni")
import("//third_party/closure_compiler/compile_js.gni")
......@@ -137,7 +138,7 @@ if (is_win) {
# libmirclient -> libmirprotobuf -> libprotobuf-lite. Trying to load
# the system libprotobuf-lite after already having loaded the libprotobuf_lite
# component will result in an immediate crash. (crbug.com/700120)
if (is_component_build && is_desktop_linux) {
if (is_component_build && use_gtk) {
shared_library("mirclient") {
inputs = [ "mirclient.map" ]
sources = [ "mirclient.cc" ]
......@@ -183,7 +184,7 @@ component("protobuf_lite") {
cflags = protobuf_lite_cflags
if (is_component_build && is_desktop_linux) {
if (is_component_build && use_gtk) {
deps = [ ":mirclient" ]
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment