Commit 22fc8a39 authored by kouhei@chromium.org's avatar kouhei@chromium.org

SVGMarkerElement::m_refY should be bound to refY attr rather than refX attr

This is a bug that I introduced in r164832.
This caused SMIL animation targeting <marker>'s refY to animate refX attribute instead.

TEST=svg/markers/animate-refY.svg
BUG=None

Review URL: https://codereview.chromium.org/661733002

git-svn-id: svn://svn.chromium.org/blink/trunk@183818 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent fa3e76aa
<svg xmlns="http://www.w3.org/2000/svg">
<marker id="m" markerWidth="40" markerHeight="40" refX="10" refY="30">
<rect x="5" y="15" width="20" height="10" fill="red" />
</marker>
<path d="M 50,50 L 100,100" marker-start="url(#m)" stroke="blue"/>
<rect x="45" y="35" height="10" width="20" fill="green" />
</svg>
<svg xmlns="http://www.w3.org/2000/svg">
<marker id="m" markerWidth="40" markerHeight="40" refX="10" refY="20">
<rect x="5" y="15" width="20" height="10" fill="red" />
<set attributeName="refY" attributeType="XML" to="30" begin="0s" dur="1s" fill="freeze" />
</marker>
<path d="M 50,50 L 100,100" marker-start="url(#m)" stroke="blue"/>
<rect x="45" y="35" height="10" width="20" fill="green" />
</svg>
...@@ -44,7 +44,7 @@ inline SVGMarkerElement::SVGMarkerElement(Document& document) ...@@ -44,7 +44,7 @@ inline SVGMarkerElement::SVGMarkerElement(Document& document)
: SVGElement(SVGNames::markerTag, document) : SVGElement(SVGNames::markerTag, document)
, SVGFitToViewBox(this) , SVGFitToViewBox(this)
, m_refX(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths)) , m_refX(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths))
, m_refY(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths)) , m_refY(SVGAnimatedLength::create(this, SVGNames::refYAttr, SVGLength::create(LengthModeHeight), AllowNegativeLengths))
, m_markerWidth(SVGAnimatedLength::create(this, SVGNames::markerWidthAttr, SVGLength::create(LengthModeWidth), ForbidNegativeLengths)) , m_markerWidth(SVGAnimatedLength::create(this, SVGNames::markerWidthAttr, SVGLength::create(LengthModeWidth), ForbidNegativeLengths))
, m_markerHeight(SVGAnimatedLength::create(this, SVGNames::markerHeightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths)) , m_markerHeight(SVGAnimatedLength::create(this, SVGNames::markerHeightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths))
, m_orientAngle(SVGAnimatedAngle::create(this)) , m_orientAngle(SVGAnimatedAngle::create(this))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment