Commit 22fe5b16 authored by Jin Young Hur's avatar Jin Young Hur Committed by Chromium LUCI CQ

[Passwords] Print password requirements info to password manager's internals

The info would be useful for debugging.

For example, print format is like below.
password: 2051817934, type=password, renderer_id = 207, SERVER_PREDICTION: ACCOUNT_CREATION_PASSWORD, PASSWORD_REQUIREMENTS: {priority: 10, symbols: {character_set: "!@*^#.~?$-_+&%/)`(", min: 1, max: 4294967295, }, }


Bug: 1068549
Change-Id: I1a791201962e36658160555d2aadf83f03b8c598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586297Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: default avatarMaxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837981}
parent 3583193f
......@@ -493,6 +493,7 @@ Jinho Bang <jinho.bang@samsung.com>
Jinsong Fan <fanjinsong@sogou-inc.com>
Jinsong Fan <jinsong.van@gmail.com>
Jinwoo Song <jinwoo7.song@samsung.com>
Jinyoung Hur <hur.ims@navercorp.com>
Jinyoung Hur <hurims@gmail.com>
Jitendra Kumar Sahoo <jitendra.ks@samsung.com>
Joachim Bauch <jbauch@webrtc.org>
......
......@@ -4,6 +4,7 @@
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include <sstream>
#include <string>
#include <utility>
#include <vector>
......@@ -18,6 +19,7 @@
#include "components/autofill/core/browser/logging/log_manager.h"
#include "components/autofill/core/browser/proto/server.pb.h"
#include "components/autofill/core/common/signatures.h"
#include "components/password_manager/core/browser/generation/password_requirements_spec_printer.h"
#include "components/password_manager/core/browser/password_form.h"
#include "components/password_manager/core/browser/password_form_metrics_recorder.h"
#include "components/password_manager/core/browser/password_manager.h"
......@@ -265,6 +267,12 @@ std::string BrowserSavePasswordProgressLogger::FormStructureToFieldsLogString(
if (field->generated_password_changed())
field_info += ", generated password changed";
if (field->password_requirements()) {
std::ostringstream s;
s << *field->password_requirements();
base::StrAppend(&field_info, {", PASSWORD_REQUIREMENTS: ", s.str()});
}
result += field_info + "\n";
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment