Temporary: Detect WebSocket destruction order problem

Add a CHECK() to crash the browser if a destruction order problem is
encountered.

This will be reverted once the information is collected.

BUG=641013

Review-Url: https://codereview.chromium.org/2315213002
Cr-Commit-Position: refs/heads/master@{#417522}

net/http/http_network_session.cc

@@ -256,6 +256,9 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
 HttpNetworkSession::~HttpNetworkSession() {
   base::STLDeleteElements(&response_drainers_);
   spdy_session_pool_.CloseAllSessions();
+
+  // TODO(ricea): Remove this by October 2016. See bug 641013.
+  CHECK_EQ(active_websockets_, 0);
 }
 
 void HttpNetworkSession::AddResponseDrainer(HttpResponseBodyDrainer* drainer) {

net/http/http_network_session.h

@@ -282,6 +282,10 @@ class NET_EXPORT HttpNetworkSession
                     SSLConfig* server_config,
                     SSLConfig* proxy_config) const;
 
+  // TODO(ricea): Remove this by October 2016.
+  void IncrementActiveWebSockets() { ++active_websockets_; }
+  void DecrementActiveWebSockets() { --active_websockets_; }
+
  private:
   friend class HttpNetworkSessionPeer;
 
@@ -316,6 +320,9 @@ class NET_EXPORT HttpNetworkSession
   Params params_;
 
   std::unique_ptr<base::MemoryPressureListener> memory_pressure_listener_;
+
+  // TODO(ricea): Remove this by October 2016.
+  int active_websockets_ = 0;
 };
 
 }  // namespace net

net/websockets/websocket_channel.cc

@@ -25,10 +25,13 @@
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "net/base/io_buffer.h"
+#include "net/http/http_network_session.h"  // TODO(ricea): Remove
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
+#include "net/http/http_transaction_factory.h"  // TODO(ricea): Remove
 #include "net/http/http_util.h"
 #include "net/log/net_log.h"
+#include "net/url_request/url_request_context.h"  // TODO(ricea): Remove
 #include "net/websockets/websocket_errors.h"
 #include "net/websockets/websocket_event_interface.h"
 #include "net/websockets/websocket_frame.h"
@@ -327,6 +330,14 @@ WebSocketChannel::WebSocketChannel(
       initial_frame_forwarded_(false) {}
 
 WebSocketChannel::~WebSocketChannel() {
+  // TODO(ricea): Remove this by October 2016. See bug 641013.
+  if (stream_) {
+    HttpTransactionFactory* http_transaction_factory =
+        url_request_context_->http_transaction_factory();
+    if (http_transaction_factory)
+      http_transaction_factory->GetSession()->DecrementActiveWebSockets();
+  }
+
   // The stream may hold a pointer to read_frames_, and so it needs to be
   // destroyed first.
   stream_.reset();
@@ -598,6 +609,12 @@ void WebSocketChannel::OnConnectSuccess(
 
   stream_ = std::move(stream);
 
+  // TODO(ricea): Remove this before October 2016.
+  HttpTransactionFactory* http_transaction_factory =
+      url_request_context_->http_transaction_factory();
+  if (http_transaction_factory)
+    http_transaction_factory->GetSession()->IncrementActiveWebSockets();
+
   SetState(CONNECTED);
 
   if (event_interface_->OnAddChannelResponse(stream_->GetSubProtocol(),