Revert of [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. (patchset #1...

Revert of [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2569713002/ )

Reason for revert:
Speculatively reverting because downstream device tests are failing.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a
> Cr-Commit-Position: refs/heads/master@{#437891}

TBR=marq@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2567203002
Cr-Commit-Position: refs/heads/master@{#437943}

ios/chrome/browser/ui/BUILD.gn

@@ -5,7 +5,6 @@
 import("//build/config/ios/rules.gni")
 
 source_set("ui") {
-  configs += [ "//build/config/compiler:enable_arc" ]
   sources = [
     "UIView+SizeClassSupport.h",
     "UIView+SizeClassSupport.mm",

ios/chrome/browser/ui/UIView+SizeClassSupport.mm

@@ -8,10 +8,6 @@
 #import "base/ios/ios_util.h"
 #import "ios/chrome/browser/ui/ui_util.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace {
 
 // Returns the SizeClassIdiom corresponding with |size_class|.

ios/chrome/browser/ui/animation_util.mm

@@ -9,10 +9,6 @@
 
 #include "ios/chrome/browser/ui/reversed_animation.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 CAAnimation* FrameAnimationMake(CALayer* layer,
                                 CGRect beginFrame,
                                 CGRect endFrame) {
@@ -63,7 +59,7 @@ CAAnimation* AnimationGroupMake(NSArray* animations) {
 
 CAAnimation* DelayedAnimationMake(CAAnimation* animation,
                                   CFTimeInterval delay) {
-  CAAnimation* delayedAnimation = [animation copy];
+  CAAnimation* delayedAnimation = [[animation copy] autorelease];
   if (delayedAnimation) {
     delayedAnimation.beginTime = delay;
     delayedAnimation = AnimationGroupMake(@[ delayedAnimation ]);

ios/chrome/browser/ui/background_generator.mm

@@ -10,12 +10,9 @@
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_cftyperef.h"
+#import "base/mac/scoped_nsobject.h"
 #import "ios/chrome/browser/ui/ui_util.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 // This is a utility function that may be used as a standalone helper function
 // to generate a radial gradient UIImage.
 UIImage* GetRadialGradient(CGRect backgroundRect,
@@ -51,7 +48,8 @@ UIImage* GetRadialGradient(CGRect backgroundRect,
 }
 
 void InstallBackgroundInView(UIView* view) {
-  UIImageView* imageView = [[UIImageView alloc] initWithFrame:view.bounds];
+  UIImageView* imageView =
+      [[[UIImageView alloc] initWithFrame:view.bounds] autorelease];
   imageView.image = [UIImage imageNamed:@"stack_view_background_noise.jpg"];
   imageView.contentMode = UIViewContentModeScaleAspectFill;
   imageView.autoresizingMask =

ios/chrome/browser/ui/browser_otr_state.mm

@@ -6,10 +6,6 @@
 
 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 bool IsOffTheRecordSessionActive() {
   ios::ChromeBrowserProvider* chrome_browser_provider =
       ios::GetChromeBrowserProvider();

ios/chrome/browser/ui/favicon_view.mm

@@ -4,12 +4,9 @@
 
 #import "ios/chrome/browser/ui/favicon_view.h"
 
+#include "base/mac/objc_property_releaser.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace {
 // Default corner radius for the favicon image view.
 const CGFloat kDefaultCornerRadius = 3;
@@ -17,12 +14,13 @@ const CGFloat kDefaultCornerRadius = 3;
 
 @interface FaviconViewNew () {
   // Property releaser for FaviconViewNew.
+  base::mac::ObjCPropertyReleaser _propertyReleaser_FaviconViewNew;
 }
 
 // Image view for the favicon.
-@property(nonatomic, strong) UIImageView* faviconImageView;
+@property(nonatomic, retain) UIImageView* faviconImageView;
 // Label for fallback favicon placeholder.
-@property(nonatomic, strong) UILabel* faviconFallbackLabel;
+@property(nonatomic, retain) UILabel* faviconFallbackLabel;
 
 @end
 
@@ -33,6 +31,7 @@ const CGFloat kDefaultCornerRadius = 3;
 - (instancetype)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
+    _propertyReleaser_FaviconViewNew.Init(self, [FaviconViewNew class]);
     _faviconImageView = [[UIImageView alloc] initWithFrame:self.bounds];
     _faviconImageView.clipsToBounds = YES;
     _faviconImageView.layer.cornerRadius = kDefaultCornerRadius;

ios/chrome/browser/ui/file_locations.mm

@@ -9,10 +9,6 @@
 #include "base/strings/sys_string_conversions.h"
 #include "ios/chrome/browser/application_context.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace {
 // English is the default locale for the Terms of Service.
 const char kEnglishLocale[] = "en";

ios/chrome/browser/ui/image_util.mm

@@ -9,10 +9,6 @@
 #include "ui/gfx/color_analysis.h"
 #include "ui/gfx/image/image.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 UIColor* DominantColorForImage(const gfx::Image& image, CGFloat opacity) {
   SkColor color = color_utils::CalculateKMeanColorOfBitmap(*image.ToSkBitmap());
   UIColor* result = [UIColor colorWithRed:SkColorGetR(color) / 255.0

ios/chrome/browser/ui/native_content_controller.h

@@ -20,7 +20,7 @@ class GURL;
 @interface NativeContentController : NSObject<CRWNativeContent>
 
 // Top-level view.
-@property(nonatomic, strong) IBOutlet UIView* view;
+@property(nonatomic, retain) IBOutlet UIView* view;
 @property(nonatomic, copy) NSString* title;
 @property(nonatomic, readonly, assign) const GURL& url;
 

ios/chrome/browser/ui/native_content_controller.mm

@@ -8,13 +8,11 @@
 
 #include "base/mac/bundle_locations.h"
 #import "base/mac/foundation_util.h"
-
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
+#include "base/mac/objc_property_releaser.h"
 
 @implementation NativeContentController {
   GURL _url;
+  base::mac::ObjCPropertyReleaser _propertyReleaser_NativeContentController;
 }
 
 @synthesize view = _view;
@@ -24,6 +22,8 @@
 - (instancetype)initWithNibName:(NSString*)nibName url:(const GURL&)url {
   self = [super init];
   if (self) {
+    _propertyReleaser_NativeContentController.Init(
+        self, [NativeContentController class]);
     if (nibName.length) {
       [base::mac::FrameworkBundle() loadNibNamed:nibName
                                            owner:self
@@ -34,12 +34,18 @@
   return self;
 }
 
+- (instancetype)init {
+  NOTREACHED();
+  return nil;
+}
+
 - (instancetype)initWithURL:(const GURL&)url {
   return [self initWithNibName:nil url:url];
 }
 
 - (void)dealloc {
   [_view removeFromSuperview];
+  [super dealloc];
 }
 
 #pragma mark CRWNativeContent

ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm

@@ -7,10 +7,6 @@
 #include "base/logging.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 @implementation OrientationLimitingNavigationController
 
 - (NSUInteger)supportedInterfaceOrientations {

ios/chrome/browser/ui/reversed_animation.mm

@@ -9,10 +9,7 @@
 #include <cmath>
 
 #include "base/logging.h"
-
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
+#include "base/mac/objc_property_releaser.h"
 
 @protocol ReversedAnimationProtocol;
 typedef CAAnimation<ReversedAnimationProtocol> ReversedAnimation;
@@ -63,7 +60,10 @@ void UpdateReversedAnimation(ReversedAnimation* reversedAnimation,
 
 #pragma mark - ReversedBasicAnimation
 
-@interface ReversedBasicAnimation : CABasicAnimation<ReversedAnimationProtocol>
+@interface ReversedBasicAnimation
+    : CABasicAnimation<ReversedAnimationProtocol> {
+  base::mac::ObjCPropertyReleaser _propertyReleaser_ReversedBasicAnimation;
+}
 
 // Returns an animation that performs |animation| in reverse when added to
 // |layer|.  |parentBeginTime| should be set to the beginTime in absolute time
@@ -81,6 +81,15 @@ void UpdateReversedAnimation(ReversedAnimation* reversedAnimation,
 @synthesize animationDirection = _animationDirection;
 @synthesize animationTimeOffset = _animationTimeOffset;
 
+- (instancetype)init {
+  self = [super init];
+  if (self) {
+    _propertyReleaser_ReversedBasicAnimation.Init(
+        self, [ReversedBasicAnimation class]);
+  }
+  return self;
+}
+
 - (instancetype)copyWithZone:(NSZone*)zone {
   ReversedBasicAnimation* copy = [super copyWithZone:zone];
   copy.originalAnimation = self.originalAnimation;
@@ -127,7 +136,10 @@ void UpdateReversedAnimation(ReversedAnimation* reversedAnimation,
 
 #pragma mark - ReversedAnimationGroup
 
-@interface ReversedAnimationGroup : CAAnimationGroup<ReversedAnimationProtocol>
+@interface ReversedAnimationGroup
+    : CAAnimationGroup<ReversedAnimationProtocol> {
+  base::mac::ObjCPropertyReleaser _propertyReleaser_ReversedAnimationGroup;
+}
 
 // Returns an animation that performs |animation| in reverse when added to
 // |layer|.  |parentBeginTime| should be set to the beginTime in absolute time
@@ -145,6 +157,15 @@ void UpdateReversedAnimation(ReversedAnimation* reversedAnimation,
 @synthesize animationDirection = _animationDirection;
 @synthesize animationTimeOffset = _animationTimeOffset;
 
+- (instancetype)init {
+  self = [super init];
+  if (self) {
+    _propertyReleaser_ReversedAnimationGroup.Init(
+        self, [ReversedAnimationGroup class]);
+  }
+  return self;
+}
+
 - (instancetype)copyWithZone:(NSZone*)zone {
   ReversedAnimationGroup* copy = [super copyWithZone:zone];
   copy.originalAnimation = self.originalAnimation;

ios/chrome/browser/ui/rtl_geometry.mm

@@ -10,10 +10,6 @@
 #include "base/logging.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 bool UseRTLLayout() {
   return base::i18n::IsRTL();
 }

ios/chrome/browser/ui/show_mail_composer_util.mm

@@ -7,14 +7,11 @@
 #include <UIKit/UIKit.h>
 
 #include "base/logging.h"
+#include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #include "ios/chrome/browser/ui/commands/show_mail_composer_command.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 void ShowMailComposer(const base::string16& to_recipient,
                       const base::string16& subject,
                       const base::string16& body,
@@ -22,12 +19,13 @@ void ShowMailComposer(const base::string16& to_recipient,
                       const base::FilePath& text_file_to_attach,
                       int email_not_configured_alert_title_id,
                       int email_not_configured_alert_message_id) {
-  ShowMailComposerCommand* command = [[ShowMailComposerCommand alloc]
+  base::scoped_nsobject<ShowMailComposerCommand>
+  command([[ShowMailComposerCommand alloc]
                    initWithToRecipient:base::SysUTF16ToNSString(to_recipient)
                                subject:base::SysUTF16ToNSString(subject)
                                   body:base::SysUTF16ToNSString(body)
         emailNotConfiguredAlertTitleId:email_not_configured_alert_title_id
-      emailNotConfiguredAlertMessageId:email_not_configured_alert_message_id];
+      emailNotConfiguredAlertMessageId:email_not_configured_alert_message_id]);
   [command setTextFileToAttach:text_file_to_attach];
   UIWindow* main_window = [[UIApplication sharedApplication] keyWindow];
   DCHECK(main_window);

ios/chrome/browser/ui/show_privacy_settings_util.mm

@@ -4,17 +4,15 @@
 
 #import "ios/chrome/browser/ui/show_privacy_settings_util.h"
 
+#import "base/mac/scoped_nsobject.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 void ShowClearBrowsingData() {
-  GenericChromeCommand* command = [[GenericChromeCommand alloc]
-      initWithTag:IDC_SHOW_CLEAR_BROWSING_DATA_SETTINGS];
+  base::scoped_nsobject<GenericChromeCommand> command(
+      [[GenericChromeCommand alloc]
+          initWithTag:IDC_SHOW_CLEAR_BROWSING_DATA_SETTINGS]);
   UIWindow* main_window = [[UIApplication sharedApplication] keyWindow];
   [main_window chromeExecuteCommand:command];
 }

ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm

@@ -8,10 +8,6 @@
 
 #include "base/logging.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace {
 
 // The absolute maximum swipe angle from |x = y| for a swipe to begin.

ios/chrome/browser/ui/ui_util.mm

@@ -10,10 +10,6 @@
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ui/gfx/ios/uikit_util.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 bool IsIPadIdiom() {
   UIUserInterfaceIdiom idiom = [[UIDevice currentDevice] userInterfaceIdiom];
   return idiom == UIUserInterfaceIdiomPad;

ios/chrome/browser/ui/uikit_ui_util.mm

@@ -15,6 +15,7 @@
 #include "base/ios/ios_util.h"
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
+#include "base/mac/scoped_nsobject.h"
 #include "ios/chrome/browser/experimental_flags.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #include "ios/web/public/web_thread.h"
@@ -23,10 +24,6 @@
 #include "ui/gfx/ios/uikit_util.h"
 #include "ui/gfx/scoped_cg_context_save_gstate_mac.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace {
 
 // Linearly interpolate between |a| and |b| by fraction |f|. Satisfies
@@ -555,8 +552,8 @@ void ApplyVisualConstraintsWithMetricsAndOptions(
     NSDictionary* subviewsDictionary,
     NSDictionary* metrics,
     NSLayoutFormatOptions options) {
-  NSMutableArray* layoutConstraints =
-      [NSMutableArray arrayWithCapacity:constraints.count * 3];
+  base::scoped_nsobject<NSMutableArray> layoutConstraints(
+      [[NSMutableArray arrayWithCapacity:constraints.count * 3] retain]);
   for (NSString* constraint in constraints) {
     DCHECK([constraint isKindOfClass:[NSString class]]);
     [layoutConstraints addObjectsFromArray: