Commit 2346288a authored by Ioana Pandele's avatar Ioana Pandele Committed by Commit Bot

Add field trial testing config for password and safety check

Make sure that tests which were not meant for Safety Check explicitly
disable the feature.

Bug: 1070620, 1092444
Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866
Auto-Submit: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: default avatarNatalie Chouinard <chouinard@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807803}
parent 30f6a4ab
...@@ -143,9 +143,14 @@ public class MainSettingsFragmentTest { ...@@ -143,9 +143,14 @@ public class MainSettingsFragmentTest {
Mockito.doReturn(SEARCH_ENGINE_SHORT_NAME).when(mMockSearchEngine).getShortName(); Mockito.doReturn(SEARCH_ENGINE_SHORT_NAME).when(mMockSearchEngine).getShortName();
} }
/**
* TODO(crbug.com/1128924): Add a corresponding test case to support Safety Check being
* enabled.
*/
@Test @Test
@LargeTest @LargeTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@DisableFeatures({ChromeFeatureList.SAFETY_CHECK_ANDROID})
public void testRenderDifferentSignedInStates() throws IOException { public void testRenderDifferentSignedInStates() throws IOException {
launchSettingsActivity(); launchSettingsActivity();
View view = mSettingsActivityTestRule.getActivity() View view = mSettingsActivityTestRule.getActivity()
...@@ -161,9 +166,12 @@ public class MainSettingsFragmentTest { ...@@ -161,9 +166,12 @@ public class MainSettingsFragmentTest {
/** /**
* Test for the "Account" section. * Test for the "Account" section.
*
* TODO(crbug.com/1128924): Add a corresponding test case to support Safety Check being enabled.
*/ */
@Test @Test
@SmallTest @SmallTest
@DisableFeatures({ChromeFeatureList.SAFETY_CHECK_ANDROID})
public void testStartup() { public void testStartup() {
launchSettingsActivity(); launchSettingsActivity();
...@@ -207,10 +215,13 @@ public class MainSettingsFragmentTest { ...@@ -207,10 +215,13 @@ public class MainSettingsFragmentTest {
/** /**
* Test for the "Account" section. * Test for the "Account" section.
*
* TODO(crbug.com/1128924): Add a corresponding test case to support Safety Check being enabled.
*/ */
@Test @Test
@SmallTest @SmallTest
@Features.EnableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY}) @Features.EnableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
@DisableFeatures({ChromeFeatureList.SAFETY_CHECK_ANDROID})
public void testStartupWithMobileIdentityConsistency() { public void testStartupWithMobileIdentityConsistency() {
launchSettingsActivity(); launchSettingsActivity();
......
...@@ -6268,6 +6268,22 @@ ...@@ -6268,6 +6268,22 @@
] ]
} }
], ],
"SafetyAndPasswordCheckAndroid": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"PasswordCheck",
"SafetyCheckAndroid"
]
}
]
}
],
"SafetyCheckChromeCleanerChild": [ "SafetyCheckChromeCleanerChild": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment