Commit 236e0583 authored by Robert Sesek's avatar Robert Sesek Committed by Commit Bot

crash_keys: Convert keys in //android_webview to the new API.

Bug: 598854
Change-Id: I0f2ad410d87e27bac5686091b31fbbab311acf14
Reviewed-on: https://chromium-review.googlesource.com/820855Reviewed-by: default avatarTobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523508}
parent 745e1b45
...@@ -38,9 +38,6 @@ size_t RegisterWebViewCrashKeys() { ...@@ -38,9 +38,6 @@ size_t RegisterWebViewCrashKeys() {
{kVariations, kHugeSize}, {kVariations, kHugeSize},
{kShutdownType, kSmallSize}, {kShutdownType, kSmallSize},
{kBrowserUnpinTrace, kMediumSize}, {kBrowserUnpinTrace, kMediumSize},
{kAppPackageName, kSmallSize},
{kAppPackageVersionCode, kSmallSize},
{kAndroidSdkInt, kSmallSize},
// content/: // content/:
{"discardable-memory-allocated", kSmallSize}, {"discardable-memory-allocated", kSmallSize},
......
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
#include "base/android/build_info.h" #include "base/android/build_info.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/cpu.h" #include "base/cpu.h"
#include "base/debug/crash_logging.h"
#include "base/i18n/icu_util.h" #include "base/i18n/icu_util.h"
#include "base/lazy_instance.h" #include "base/lazy_instance.h"
#include "base/logging.h" #include "base/logging.h"
...@@ -31,6 +30,7 @@ ...@@ -31,6 +30,7 @@
#include "base/threading/thread_restrictions.h" #include "base/threading/thread_restrictions.h"
#include "cc/base/switches.h" #include "cc/base/switches.h"
#include "components/crash/content/app/breakpad_linux.h" #include "components/crash/content/app/breakpad_linux.h"
#include "components/crash/core/common/crash_key.h"
#include "components/safe_browsing/android/safe_browsing_api_handler_bridge.h" #include "components/safe_browsing/android/safe_browsing_api_handler_bridge.h"
#include "components/spellcheck/common/spellcheck_features.h" #include "components/spellcheck/common/spellcheck_features.h"
#include "content/public/browser/android/browser_media_player_manager_register.h" #include "content/public/browser/android/browser_media_player_manager_register.h"
...@@ -210,13 +210,18 @@ void AwMainDelegate::PreSandboxStartup() { ...@@ -210,13 +210,18 @@ void AwMainDelegate::PreSandboxStartup() {
base::android::BuildInfo* android_build_info = base::android::BuildInfo* android_build_info =
base::android::BuildInfo::GetInstance(); base::android::BuildInfo::GetInstance();
base::debug::SetCrashKeyValue(crash_keys::kAppPackageName,
android_build_info->package_name()); static ::crash_reporter::CrashKeyString<64> app_name_key(
base::debug::SetCrashKeyValue(crash_keys::kAppPackageVersionCode, crash_keys::kAppPackageName);
android_build_info->package_version_code()); app_name_key.Set(android_build_info->package_name());
base::debug::SetCrashKeyValue(
crash_keys::kAndroidSdkInt, static ::crash_reporter::CrashKeyString<64> app_version_key(
base::IntToString(android_build_info->sdk_int())); crash_keys::kAppPackageVersionCode);
app_version_key.Set(android_build_info->package_version_code());
static ::crash_reporter::CrashKeyString<8> sdk_int_key(
crash_keys::kAndroidSdkInt);
sdk_int_key.Set(base::IntToString(android_build_info->sdk_int()));
} }
int AwMainDelegate::RunProcess( int AwMainDelegate::RunProcess(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment