Commit 2370aba4 authored by Alexander Cooper's avatar Alexander Cooper Committed by Commit Bot

Define XrDestroySession for FakeOpenXrImpl

Some tests were currently failing on code that (seemed to be) trying to
call XrDestroySession, which was not defined by the FakeOpenXrImpl API.
This change defines that method, so the tests that were disabled should
be passing again. If the flakes still occur, some logging will need to
be upgraded to DLOG(ERROR), so that we can get a better idea of what's
going on, since there is some amount of distrust of the callstacks.

Fixed: 1115721
Change-Id: Ibeb8fdeb38c84da83be886cf6a02b53289d76b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354523Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarBrandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797907}
parent 390ff97d
......@@ -127,7 +127,7 @@ void TestWebXRSessionEndWhenEventTriggered(
t->EndTest();
}
IN_PROC_BROWSER_TEST_F(WebXrVrOpenXrBrowserTest, DISABLED_TestSessionEnded) {
IN_PROC_BROWSER_TEST_F(WebXrVrOpenXrBrowserTest, TestSessionEnded) {
TestWebXRSessionEndWhenEventTriggered(
this, device_test::mojom::EventType::kSessionLost);
}
......
......@@ -291,6 +291,12 @@ XrResult xrDestroyInstance(XrInstance instance) {
return XR_SUCCESS;
}
XrResult xrDestroySession(XrSession session) {
DVLOG(2) << __FUNCTION__;
RETURN_IF_XR_FAILED(g_test_helper.ValidateSession(session));
return XR_SUCCESS;
}
XrResult xrDestroySpace(XrSpace space) {
DVLOG(2) << __FUNCTION__;
RETURN_IF_XR_FAILED(g_test_helper.ValidateSpace(space));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment