bindings: Map IDLDate to base::Optional<base::Time> instead of double

* Rename IDLDate to IDLDateOrNull to reflect the reality
* Rename ToCoreDate to ToCoreNullableDate
* Change |double| argument of InputType::SetValueAsDate() to
  base::Optional<base::Time>
* Change |double| argument of |BaseTemporalInputType::
  SerializeWithMilliseconds| to base::Optional<base::Time>
* Rename SerializeWithMilliseconds to SerializeWithDate

This CL has no behavior changes.

Change-Id: I2d8476821317a4577ddcf26a2c88eb9809425ed9
Bug: 988343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928512
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717609}

third_party/blink/renderer/bindings/core/v8/idl_types.h

@@ -7,6 +7,7 @@
 
 #include <type_traits>
 #include "base/optional.h"
+#include "base/time/time.h"
 #include "third_party/blink/renderer/bindings/core/v8/idl_types_base.h"
 #include "third_party/blink/renderer/bindings/core/v8/native_value_traits.h"
 #include "third_party/blink/renderer/bindings/core/v8/v8_string_resource.h"
@@ -87,9 +88,9 @@ struct IDLUnrestrictedDouble final : public IDLBaseHelper<double> {};
 struct IDLFloat final : public IDLBaseHelper<float> {};
 struct IDLUnrestrictedFloat final : public IDLBaseHelper<float> {};
 
-// Date
-// TODO(crbug.com/988343): Change |double| to |base::Time|.
-struct IDLDate final : public IDLBaseHelper<double> {};
+// Nullable Date
+struct IDLDateOrNull final : public IDLBaseHelper<base::Optional<base::Time>> {
+};
 
 // Promise
 struct IDLPromise final : public IDLBaseHelper<ScriptPromise> {};

third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.h

@@ -396,12 +396,13 @@ struct CORE_EXPORT NativeValueTraits<IDLPromise>
 
 // Type-specific overloads
 template <>
-struct CORE_EXPORT NativeValueTraits<IDLDate>
-    : public NativeValueTraitsBase<IDLDate> {
-  static double NativeValue(v8::Isolate* isolate,
-                            v8::Local<v8::Value> value,
-                            ExceptionState& exception_state) {
-    return ToCoreDate(isolate, value, exception_state);
+struct CORE_EXPORT NativeValueTraits<IDLDateOrNull>
+    : public NativeValueTraitsBase<IDLDateOrNull> {
+  static base::Optional<base::Time> NativeValue(
+      v8::Isolate* isolate,
+      v8::Local<v8::Value> value,
+      ExceptionState& exception_state) {
+    return ToCoreNullableDate(isolate, value, exception_state);
   }
 };
 

third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h

@@ -387,16 +387,24 @@ CORE_EXPORT float ToRestrictedFloat(v8::Isolate*,
                                     v8::Local<v8::Value>,
                                     ExceptionState&);
 
-inline double ToCoreDate(v8::Isolate* isolate,
-                         v8::Local<v8::Value> object,
-                         ExceptionState& exception_state) {
+inline base::Optional<base::Time> ToCoreNullableDate(
+    v8::Isolate* isolate,
+    v8::Local<v8::Value> object,
+    ExceptionState& exception_state) {
+  // https://html.spec.whatwg.org/C/#common-input-element-apis:dom-input-valueasdate-2
+  //   ... otherwise if the new value is null or a Date object representing the
+  //   NaN time value, then set the value of the element to the empty string;
+  // We'd like to return same values for |null| and an invalid Date object.
   if (object->IsNull())
-    return std::numeric_limits<double>::quiet_NaN();
+    return base::nullopt;
   if (!object->IsDate()) {
     exception_state.ThrowTypeError("The provided value is not a Date.");
-    return 0;
+    return base::nullopt;
   }
-  return object.As<v8::Date>()->ValueOf();
+  double time_value = object.As<v8::Date>()->ValueOf();
+  if (!std::isfinite(time_value))
+    return base::nullopt;
+  return base::Time::FromJsTime(time_value);
 }
 
 // USVString conversion helper.

third_party/blink/renderer/core/html/forms/base_temporal_input_type.cc

@@ -66,9 +66,10 @@ double BaseTemporalInputType::ValueAsDate() const {
   return ValueAsDouble();
 }
 
-void BaseTemporalInputType::SetValueAsDate(double value,
-                                           ExceptionState&) const {
-  GetElement().setValue(SerializeWithMilliseconds(value));
+void BaseTemporalInputType::SetValueAsDate(
+    const base::Optional<base::Time>& value,
+    ExceptionState&) const {
+  GetElement().setValue(SerializeWithDate(value));
 }
 
 double BaseTemporalInputType::ValueAsDouble() const {
@@ -154,8 +155,11 @@ String BaseTemporalInputType::SerializeWithComponents(
   return date.ToString(DateComponents::kMillisecond);
 }
 
-String BaseTemporalInputType::SerializeWithMilliseconds(double value) const {
-  return Serialize(Decimal::FromDouble(value));
+String BaseTemporalInputType::SerializeWithDate(
+    const base::Optional<base::Time>& value) const {
+  if (!value)
+    return g_empty_string;
+  return Serialize(Decimal::FromDouble(value->ToJsTimeIgnoringNull()));
 }
 
 String BaseTemporalInputType::LocalizeValue(

third_party/blink/renderer/core/html/forms/base_temporal_input_type.h

@@ -85,7 +85,8 @@ class BaseTemporalInputType : public InputType {
   InputTypeView* CreateView() override;
   ValueMode GetValueMode() const override;
   double ValueAsDate() const override;
-  void SetValueAsDate(double, ExceptionState&) const override;
+  void SetValueAsDate(const base::Optional<base::Time>&,
+                      ExceptionState&) const override;
   double ValueAsDouble() const override;
   void SetValueAsDouble(double,
                         TextFieldEventBehavior,
@@ -97,7 +98,7 @@ class BaseTemporalInputType : public InputType {
   String RangeUnderflowText(const Decimal& minimum) const override;
   Decimal DefaultValueForStepUp() const override;
   bool IsSteppable() const override;
-  virtual String SerializeWithMilliseconds(double) const;
+  virtual String SerializeWithDate(const base::Optional<base::Time>&) const;
   String LocalizeValue(const String&) const override;
   bool SupportsReadOnly() const override;
   bool ShouldRespectListAttribute() override;

third_party/blink/renderer/core/html/forms/date_time_local_input_type.cc

@@ -62,7 +62,7 @@ double DateTimeLocalInputType::ValueAsDate() const {
 }
 
 void DateTimeLocalInputType::SetValueAsDate(
-    double value,
+    const base::Optional<base::Time>& value,
     ExceptionState& exception_state) const {
   // valueAsDate doesn't work for the datetime-local type according to the
   // standard.

third_party/blink/renderer/core/html/forms/date_time_local_input_type.h

@@ -46,7 +46,8 @@ class DateTimeLocalInputType final : public BaseTemporalInputType {
   void CountUsage() override;
   const AtomicString& FormControlType() const override;
   double ValueAsDate() const override;
-  void SetValueAsDate(double, ExceptionState&) const override;
+  void SetValueAsDate(const base::Optional<base::Time>&,
+                      ExceptionState&) const override;
   StepRange CreateStepRange(AnyStepHandling) const override;
   bool ParseToDateComponentsInternal(const String&,
                                      DateComponents*) const override;

third_party/blink/renderer/core/html/forms/html_input_element.cc

@@ -1211,11 +1211,12 @@ ScriptValue HTMLInputElement::valueAsDate(ScriptState* script_state) const {
 void HTMLInputElement::setValueAsDate(ScriptState* script_state,
                                       const ScriptValue& value,
                                       ExceptionState& exception_state) {
-  double date_ms = NativeValueTraits<IDLDate>::NativeValue(
-      script_state->GetIsolate(), value.V8Value(), exception_state);
+  base::Optional<base::Time> date =
+      NativeValueTraits<IDLDateOrNull>::NativeValue(
+          script_state->GetIsolate(), value.V8Value(), exception_state);
   if (exception_state.HadException())
     return;
-  input_type_->SetValueAsDate(date_ms, exception_state);
+  input_type_->SetValueAsDate(date, exception_state);
 }
 
 double HTMLInputElement::valueAsNumber() const {

third_party/blink/renderer/core/html/forms/input_type.cc

@@ -226,7 +226,8 @@ double InputType::ValueAsDate() const {
   return DateComponents::InvalidMilliseconds();
 }
 
-void InputType::SetValueAsDate(double, ExceptionState& exception_state) const {
+void InputType::SetValueAsDate(const base::Optional<base::Time>&,
+                               ExceptionState& exception_state) const {
   exception_state.ThrowDOMException(
       DOMExceptionCode::kInvalidStateError,
       "This input element does not support Date values.");

third_party/blink/renderer/core/html/forms/input_type.h

@@ -95,7 +95,8 @@ class CORE_EXPORT InputType : public GarbageCollected<InputType> {
   virtual ValueMode GetValueMode() const = 0;
 
   virtual double ValueAsDate() const;
-  virtual void SetValueAsDate(double, ExceptionState&) const;
+  virtual void SetValueAsDate(const base::Optional<base::Time>&,
+                              ExceptionState&) const;
   virtual double ValueAsDouble() const;
   virtual void SetValueAsDouble(double,
                                 TextFieldEventBehavior,

third_party/blink/renderer/core/html/forms/month_input_type.cc

@@ -64,9 +64,11 @@ double MonthInputType::ValueAsDate() const {
   return msec;
 }
 
-String MonthInputType::SerializeWithMilliseconds(double value) const {
+String MonthInputType::SerializeWithDate(
+    const base::Optional<base::Time>& value) const {
   DateComponents date;
-  if (!date.SetMillisecondsSinceEpochForMonth(value))
+  if (!value ||
+      !date.SetMillisecondsSinceEpochForMonth(value->ToJsTimeIgnoringNull()))
     return String();
   return SerializeWithComponents(date);
 }

third_party/blink/renderer/core/html/forms/month_input_type.h

@@ -44,7 +44,7 @@ class MonthInputType final : public BaseTemporalInputType {
   void CountUsage() override;
   const AtomicString& FormControlType() const override;
   double ValueAsDate() const override;
-  String SerializeWithMilliseconds(double) const override;
+  String SerializeWithDate(const base::Optional<base::Time>&) const override;
   Decimal ParseToNumber(const String&, const Decimal&) const override;
   Decimal DefaultValueForStepUp() const override;
   StepRange CreateStepRange(AnyStepHandling) const override;