Commit 23bcf533 authored by Fredrik Söderquist's avatar Fredrik Söderquist Committed by Commit Bot

Fixes and tweaks to wpt/css/filter-effects/

filter-contrast-003.html

  Adjust the color from #400000 to #3f0000, since (0x40 / 255) is just
  over 0.25 and can after filtering and rounding end up above 0.
  (0x3f / 255) on the other hand is just below 0.25 and the result will
  be clamped to zero.

filter-external-001-test.html
filter-external-002-test.html

  Change the hue-rotate parameter in the external file from 120 to 150.
  Move the file to support/ and remove lint entry.
  Make both filters operate in sRGB to make computing the reference
  easier. Use rgb(...) notation with percentage values in reference.

fecolormatrix-type.html

  Add color-interpolation-filters=sRGB to the filter to make it easier
  to reason about what the result should be. Use rgba(...) notation in
  the ref using percentage notation.

filters-test-brightness-003.html

  Add 'filter: brightness(0)' before 'filter: brightness()' to properly
  test if the "no argument" notation is considered valid by the parser.

filter-grayscale-001.html
filter-grayscale-002.html
filter-grayscale-003.html
filter-grayscale-004.html
filter-grayscale-005.html

  Remove the " (and not blue)" text from the reference and update the
  001,004 and 005 tests accordingly.

css-filters-animation-saturate.html

  Interpolate the argument from 4900% rather than 5000% to end at the
  ref's 2500% (25).

css-filters-animation-hue-rotate.html

  Sample the animation at .5 to match the expectation.

css-filters-animation-drop-shadow.html

  Use explicit rgba(...) in the ref rather than the keyword 'gray'.
  We're interpolating the color of the drop-shadow from 'black'
  (rgba(0, 0, 0, 1)) to 'transparent' (rgba(0, 0, 0, 0)) here, so it's
  better and more accurate to describe the color as "semi-transparent
  black" (rgba(0, 0, 0, 0.5)).

css-filters-animation-combined-001.html

  Initial value for animation for 'opacity(...)' is '1' - not zero.
  Change test to interpolate from 0 -> 1 (rather than 1 -> 1)

Bug: 903383
Change-Id: I4d0113989414616494b98c22fbac817f007cd762
Reviewed-on: https://chromium-review.googlesource.com/c/1333816Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#607628}
parent 68c381e3
...@@ -2889,19 +2889,10 @@ crbug.com/893480 external/wpt/infrastructure/testdriver/actions/multiDevice.html ...@@ -2889,19 +2889,10 @@ crbug.com/893480 external/wpt/infrastructure/testdriver/actions/multiDevice.html
# ====== New tests from wpt-importer added here ====== # ====== New tests from wpt-importer added here ======
crbug.com/626703 virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html [ Timeout ] crbug.com/626703 virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html [ Timeout ]
crbug.com/626703 external/wpt/webrtc/RTCPeerConnection-track-stats.https.html [ Timeout ] crbug.com/626703 external/wpt/webrtc/RTCPeerConnection-track-stats.https.html [ Timeout ]
crbug.com/626703 external/wpt/css/filter-effects/filter-grayscale-003.html [ Failure ] crbug.com/903383 external/wpt/css/filter-effects/filter-cb-abspos-inline-003.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/filter-grayscale-002.html [ Failure ] crbug.com/903383 external/wpt/css/filter-effects/css-filters-animation-combined-001.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/filter-external-002-test.html [ Failure ] crbug.com/903383 external/wpt/css/filter-effects/css-filters-animation-blur.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/filter-cb-abspos-inline-003.html [ Failure ] crbug.com/903383 external/wpt/css/filter-effects/filters-test-brightness-003.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/css-filters-animation-saturate.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/css-filters-animation-hue-rotate.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/css-filters-animation-combined-001.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/filter-external-001-test.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/css-filters-animation-drop-shadow.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/css-filters-animation-blur.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/filters-test-brightness-003.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/filter-contrast-003.html [ Failure ]
crbug.com/626703 external/wpt/css/filter-effects/fecolormatrix-type.html [ Failure ]
crbug.com/626703 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width.html [ Timeout ] crbug.com/626703 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width.html [ Timeout ]
crbug.com/626703 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html [ Timeout ] crbug.com/626703 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html [ Timeout ]
crbug.com/626703 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html [ Timeout ] crbug.com/626703 external/wpt/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html [ Timeout ]
......
...@@ -28,7 +28,7 @@ ...@@ -28,7 +28,7 @@
saturate(0%) saturate(0%)
hue-rotate(90deg) hue-rotate(90deg)
invert(100%) invert(100%)
opacity(100%) opacity(0%)
} }
100% { 100% {
filter: none; filter: none;
......
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
width: 100px; width: 100px;
height: 100px; height: 100px;
background: blue; background: blue;
filter: drop-shadow(15px 15px 0px gray); filter: drop-shadow(15px 15px 0px rgba(0, 0, 0, 0.5));
} }
</style> </style>
</head> </head>
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
<link rel="help" href="http://www.w3.org/TR/filter-effects-1/#funcdef-drop-shadow"> <link rel="help" href="http://www.w3.org/TR/filter-effects-1/#funcdef-drop-shadow">
<link rel="help" href="http://www.w3.org/TR/css3-animations/#animations"> <link rel="help" href="http://www.w3.org/TR/css3-animations/#animations">
<link rel="match" href="css-filters-animation-drop-shadow-ref.html"> <link rel="match" href="css-filters-animation-drop-shadow-ref.html">
<meta name="assert" content="The blue square should be in top of a gray one"> <meta name="assert" content="The blue square should be on top of a gray one">
<style type="text/css"> <style type="text/css">
@keyframes animate { @keyframes animate {
0% { 0% {
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
background: blue; background: blue;
animation-name: animate; animation-name: animate;
animation-play-state: paused; animation-play-state: paused;
animation-delay: -1s; animation-delay: -2s;
animation-duration: 4s; animation-duration: 4s;
animation-timing-function: linear; animation-timing-function: linear;
} }
......
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
<style type="text/css"> <style type="text/css">
@keyframes animate { @keyframes animate {
0% { 0% {
filter: saturate(5000%); filter: saturate(4900%);
} }
100% { 100% {
filter: none; filter: none;
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
div{ div{
width: 200px; width: 200px;
height: 200px; height: 200px;
background-color: #a8d7c1; background-color: rgba(39.3%, 68.6%, 53.4%, 1);
} }
</style> </style>
......
...@@ -28,7 +28,7 @@ ...@@ -28,7 +28,7 @@
<div></div> <div></div>
<svg> <svg>
<filter id="sepia"> <filter id="sepia" color-interpolation-filters="sRGB">
<feColorMatrix type="matrix" values="0.393 0.189 0.349 0 0 <feColorMatrix type="matrix" values="0.393 0.189 0.349 0 0
0.686 0.168 0.272 0 0 0.686 0.168 0.272 0 0
0.534 0.131 0 0 0 0.534 0.131 0 0 0
......
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<head> <head>
<title>CSS Filter contrast: Test for CSS contrast filter shotrhand</title> <title>CSS Filter contrast: Test for CSS contrast filter shorthand</title>
<link rel="author" title="Takeshi Kurosawa" href="mailto:taken.spc@gmail.com"> <link rel="author" title="Takeshi Kurosawa" href="mailto:taken.spc@gmail.com">
<link rel="reviewer" title="Dirk Schulze" href="mailto:dschulze@adobe.com"> <link rel="reviewer" title="Dirk Schulze" href="mailto:dschulze@adobe.com">
<link rel="help" href="http://www.w3.org/TR/filter-effects-1/#FilterProperty"> <link rel="help" href="http://www.w3.org/TR/filter-effects-1/#FilterProperty">
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
div { div {
width: 200px; width: 200px;
height: 200px; height: 200px;
background-color: #400000; background-color: #3f0000;
filter: contrast(200%); filter: contrast(200%);
} }
</style> </style>
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
div { div {
width: 200px; width: 200px;
height: 200px; height: 200px;
background: #00b60d; background: rgb(0%, 46.896%, 0.396%);
} }
</style> </style>
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
<div></div> <div></div>
<svg> <svg>
<filter id="filter"> <filter id="filter" color-interpolation-filters="sRGB">
<feColorMatrix type="hueRotate" in="SourceGraphic" values="150"/> <feColorMatrix type="hueRotate" in="SourceGraphic" values="150"/>
</filter> </filter>
</svg> </svg>
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
width: 200px; width: 200px;
height: 200px; height: 200px;
background: red; background: red;
filter: url( filter-external-002-filter.svg#filter ); filter: url( support/filter-external-002-filter.svg#filter );
} }
</style> </style>
......
...@@ -22,9 +22,9 @@ ...@@ -22,9 +22,9 @@
</style> </style>
</head> </head>
<body> <body>
<p>The test passes if the little box looks grey. (and not blue)</p> <p>The test passes if the little box looks grey.</p>
<div class="testzone"> <div class="testzone">
<div class="box filter"></div> <div class="box filter"></div>
</div> </div>
</body> </body>
</html> </html>
\ No newline at end of file
...@@ -22,9 +22,9 @@ ...@@ -22,9 +22,9 @@
</style> </style>
</head> </head>
<body> <body>
<p>The test passes if the little box looks grey. (and not blue)</p> <p>The test passes if the little box looks grey.</p>
<div class="testzone"> <div class="testzone">
<div class="box filter"></div> <div class="box filter"></div>
</div> </div>
</body> </body>
</html> </html>
\ No newline at end of file
...@@ -22,9 +22,9 @@ ...@@ -22,9 +22,9 @@
</style> </style>
</head> </head>
<body> <body>
<p>The test passes if the little box looks grey. (and not blue)</p> <p>The test passes if the little box looks grey.</p>
<div class="testzone"> <div class="testzone">
<div class="box filter"></div> <div class="box filter"></div>
</div> </div>
</body> </body>
</html> </html>
\ No newline at end of file
...@@ -16,9 +16,9 @@ ...@@ -16,9 +16,9 @@
</style> </style>
</head> </head>
<body> <body>
<p>The test passes if the little box looks grey. (and not blue)</p> <p>The test passes if the little box looks grey.</p>
<div class="testzone"> <div class="testzone">
<div class="box"></div> <div class="box"></div>
</div> </div>
</body> </body>
</html> </html>
\ No newline at end of file
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<head> <head>
<title>CSS Writing Modes Test: drop-shadow offset test</title> <title>CSS Filter Effects: brightness(...) without argument</title>
<link rel="author" title="Jun Ichikawa" href="mailto:jun1ka0@gmail.com"> <link rel="author" title="Jun Ichikawa" href="mailto:jun1ka0@gmail.com">
<link rel="reviewer" title="Dirk Schulze" href="mailto:dschulze@adobe.com"> <link rel="reviewer" title="Dirk Schulze" href="mailto:dschulze@adobe.com">
<link rel="help" href="http://www.w3.org/TR/filter-effects-1/#FilterProperty"> <link rel="help" href="http://www.w3.org/TR/filter-effects-1/#FilterProperty">
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
width: 200px; width: 200px;
height: 200px; height: 200px;
background-color: rgb(0, 255, 0); background-color: rgb(0, 255, 0);
filter: brightness(0);
filter: brightness(); filter: brightness();
} }
</style> </style>
......
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg"> <svg version="1.1" xmlns="http://www.w3.org/2000/svg">
<filter id="filter"> <filter id="filter" color-interpolation-filters="sRGB">
<feColorMatrix type="hueRotate" in="SourceGraphic" values="120"/> <feColorMatrix type="hueRotate" in="SourceGraphic" values="150"/>
</filter> </filter>
</svg> </svg>
\ No newline at end of file
...@@ -378,7 +378,6 @@ SUPPORT-WRONG-DIR: css/CSS2/section-index.xht ...@@ -378,7 +378,6 @@ SUPPORT-WRONG-DIR: css/CSS2/section-index.xht
SUPPORT-WRONG-DIR: css/CSS2/other-formats/xml/background-18.css SUPPORT-WRONG-DIR: css/CSS2/other-formats/xml/background-18.css
SUPPORT-WRONG-DIR: css/CSS2/other-formats/xml/background-19-alt.xml SUPPORT-WRONG-DIR: css/CSS2/other-formats/xml/background-19-alt.xml
SUPPORT-WRONG-DIR: css/CSS2/other-formats/xml/background-19.css SUPPORT-WRONG-DIR: css/CSS2/other-formats/xml/background-19.css
SUPPORT-WRONG-DIR: css/filter-effects/filter-external-002-filter.svg
SUPPORT-WRONG-DIR: css/vendor-imports/mozilla/mozilla-central-reftests/check-for-references.sh SUPPORT-WRONG-DIR: css/vendor-imports/mozilla/mozilla-central-reftests/check-for-references.sh
SUPPORT-WRONG-DIR: css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests-filter SUPPORT-WRONG-DIR: css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests-filter
SUPPORT-WRONG-DIR: css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests.sh SUPPORT-WRONG-DIR: css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests.sh
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment