[CodeHealth] Convert c/b/ui/views/extensions and bookmark from base::Bind and...

[CodeHealth] Convert c/b/ui/views/extensions and bookmark from base::Bind and base::Callback to Once/Repeating

Bug: 1152282
Change-Id: I9b557a75a039844183ee49eae868036fa1cfa072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592248Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837143}

chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -1419,12 +1419,13 @@ void BookmarkBarView::Init() {
   profile_pref_registrar_.Init(browser_->profile()->GetPrefs());
   profile_pref_registrar_.Add(
       bookmarks::prefs::kShowAppsShortcutInBookmarkBar,
-      base::Bind(&BookmarkBarView::OnAppsPageShortcutVisibilityPrefChanged,
-                 base::Unretained(this)));
+      base::BindRepeating(
+          &BookmarkBarView::OnAppsPageShortcutVisibilityPrefChanged,
+          base::Unretained(this)));
   profile_pref_registrar_.Add(
       bookmarks::prefs::kShowManagedBookmarksInBookmarkBar,
-      base::Bind(&BookmarkBarView::OnShowManagedBookmarksPrefChanged,
-                 base::Unretained(this)));
+      base::BindRepeating(&BookmarkBarView::OnShowManagedBookmarksPrefChanged,
+                          base::Unretained(this)));
   apps_page_shortcut_->SetVisible(
       chrome::ShouldShowAppsShortcutInBookmarkBar(browser_->profile()));
 

chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

@@ -125,7 +125,7 @@ class DialogWaiter : public aura::EnvObserver,
 
   bool dialog_created_ = false;
   views::Widget* dialog_ = nullptr;
-  base::Closure quit_closure_;
+  base::RepeatingClosure quit_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(DialogWaiter);
 };
@@ -160,7 +160,7 @@ class DialogCloseWaiter : public views::WidgetObserver {
   }
 
   bool dialog_closed_;
-  base::Closure quit_closure_;
+  base::RepeatingClosure quit_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(DialogCloseWaiter);
 };
@@ -199,7 +199,7 @@ class TabKeyWaiter : public ui::EventHandler {
 
   views::Widget* widget_;
   bool received_tab_;
-  base::Closure quit_closure_;
+  base::RepeatingClosure quit_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(TabKeyWaiter);
 };

chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

@@ -137,7 +137,7 @@ class BookmarkBarViewBaseTest : public ChromeViewsTestBase {
         static_cast<Profile*>(profile)->GetPrefs(),
         std::make_unique<SearchTermsData>(),
         nullptr /* KeywordWebDataService */,
-        nullptr /* TemplateURLServiceClient */, base::Closure());
+        nullptr /* TemplateURLServiceClient */, base::RepeatingClosure());
   }
 };
 

chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc

@@ -57,7 +57,7 @@ class TestExtensionUninstallDialogDelegate
     : public extensions::ExtensionUninstallDialog::Delegate {
  public:
   explicit TestExtensionUninstallDialogDelegate(
-      const base::Closure& quit_closure)
+      base::RepeatingClosure quit_closure)
       : quit_closure_(quit_closure), canceled_(false) {}
 
   ~TestExtensionUninstallDialogDelegate() override {}
@@ -71,7 +71,7 @@ class TestExtensionUninstallDialogDelegate
     quit_closure_.Run();
   }
 
-  base::Closure quit_closure_;
+  base::RepeatingClosure quit_closure_;
   bool canceled_;
 
   DISALLOW_COPY_AND_ASSIGN(TestExtensionUninstallDialogDelegate);

chrome/browser/ui/views/extensions/extensions_toolbar_container.cc

@@ -318,7 +318,7 @@ bool ExtensionsToolbarContainer::CloseOverflowMenuIfOpen() {
 void ExtensionsToolbarContainer::PopOutAction(
     ToolbarActionViewController* action,
     bool is_sticky,
-    const base::Closure& closure) {
+    const base::RepeatingClosure& closure) {
   // TODO(pbos): Highlight popout differently.
   DCHECK(!popped_out_action_);
   popped_out_action_ = action;

chrome/browser/ui/views/extensions/extensions_toolbar_container.h

@@ -117,7 +117,7 @@ class ExtensionsToolbarContainer : public ToolbarIconContainerView,
   bool CloseOverflowMenuIfOpen() override;
   void PopOutAction(ToolbarActionViewController* action,
                     bool is_sticky,
-                    const base::Closure& closure) override;
+                    const base::RepeatingClosure& closure) override;
   bool ShowToolbarActionPopupForAPICall(const std::string& action_id) override;
   void ShowToolbarActionBubble(
       std::unique_ptr<ToolbarActionsBarBubbleDelegate> bubble) override;