Revert 285437 "Block on LaunchProcess failing on specific bot"

scottmg told me to do this.

> Block on LaunchProcess failing on specific bot
> 
> Block in a loop if we get a specific failure on a particular bot.
> See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference.
> 
> Timeout raise attempted at https://codereview.chromium.org/410353004/ so
> that there will be time to attach a debugger.
> 
> R=brettw@chromium.org
> BUG=340422
> 
> Review URL: https://codereview.chromium.org/411223002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/414363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285734 0039d316-1c4b-4281-b951-d872f2087c98
parent 5a3c1f06
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
#include <windows.h> #include <windows.h>
#include <userenv.h> #include <userenv.h>
#include <psapi.h> #include <psapi.h>
#include <stdlib.h>
#include <ios> #include <ios>
#include <limits> #include <limits>
...@@ -206,16 +205,6 @@ bool LaunchProcess(const string16& cmdline, ...@@ -206,16 +205,6 @@ bool LaunchProcess(const string16& cmdline,
startup_info, &temp_process_info)) { startup_info, &temp_process_info)) {
DPLOG(ERROR) << "Command line:" << std::endl << UTF16ToUTF8(cmdline) DPLOG(ERROR) << "Command line:" << std::endl << UTF16ToUTF8(cmdline)
<< std::endl;; << std::endl;;
// TODO(scottmg): Temporary code for debugging http://crbug.com/340422.
if (getenv("CHROME_HEADLESS") &&
strcmp(getenv("CHROME_HEADLESS"), "1") == 0 &&
getenv("COMPUTERNAME") &&
strcmp(getenv("COMPUTERNAME"), "VM898-M1") == 0) {
for (;;) {
DLOG(ERROR) << "Failed CreateProcess, waiting for debugger";
::Sleep(1000);
}
}
return false; return false;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment