Commit 23df9693 authored by j.isorce's avatar j.isorce Committed by Commit bot

Fix build error with gcc 4.8.2 about WARN_UNUSED_RESULT

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"

Review URL: https://codereview.chromium.org/1610103002

Cr-Commit-Position: refs/heads/master@{#371479}
parent 07a9d830
...@@ -131,7 +131,7 @@ scoped_refptr<base::SequencedTaskRunner> ...@@ -131,7 +131,7 @@ scoped_refptr<base::SequencedTaskRunner>
ChromeConfigurator::GetSequencedTaskRunner() const { ChromeConfigurator::GetSequencedTaskRunner() const {
return content::BrowserThread::GetBlockingPool() return content::BrowserThread::GetBlockingPool()
->GetSequencedTaskRunnerWithShutdownBehavior( ->GetSequencedTaskRunnerWithShutdownBehavior(
content::BrowserThread::GetBlockingPool()->GetSequenceToken(), base::SequencedWorkerPool::GetSequenceToken(),
base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN); base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
} }
......
...@@ -55,7 +55,7 @@ KeyedService* DomDistillerServiceFactory::BuildServiceInstanceFor( ...@@ -55,7 +55,7 @@ KeyedService* DomDistillerServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* profile) const { content::BrowserContext* profile) const {
scoped_refptr<base::SequencedTaskRunner> background_task_runner = scoped_refptr<base::SequencedTaskRunner> background_task_runner =
content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner( content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
content::BrowserThread::GetBlockingPool()->GetSequenceToken()); base::SequencedWorkerPool::GetSequenceToken());
scoped_ptr<leveldb_proto::ProtoDatabaseImpl<ArticleEntry> > db( scoped_ptr<leveldb_proto::ProtoDatabaseImpl<ArticleEntry> > db(
new leveldb_proto::ProtoDatabaseImpl<ArticleEntry>( new leveldb_proto::ProtoDatabaseImpl<ArticleEntry>(
......
...@@ -508,7 +508,7 @@ void ProfileImplIOData::InitializeInternal( ...@@ -508,7 +508,7 @@ void ProfileImplIOData::InitializeInternal(
new QuotaPolicyChannelIDStore( new QuotaPolicyChannelIDStore(
lazy_params_->channel_id_path, lazy_params_->channel_id_path,
BrowserThread::GetBlockingPool()->GetSequencedTaskRunner( BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
BrowserThread::GetBlockingPool()->GetSequenceToken()), base::SequencedWorkerPool::GetSequenceToken()),
lazy_params_->special_storage_policy.get()); lazy_params_->special_storage_policy.get());
channel_id_service = new net::ChannelIDService( channel_id_service = new net::ChannelIDService(
new net::DefaultChannelIDStore(channel_id_db.get()), new net::DefaultChannelIDStore(channel_id_db.get()),
......
...@@ -57,7 +57,7 @@ KeyedService* SuggestionsServiceFactory::BuildServiceInstanceFor( ...@@ -57,7 +57,7 @@ KeyedService* SuggestionsServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* profile) const { content::BrowserContext* profile) const {
scoped_refptr<base::SequencedTaskRunner> background_task_runner = scoped_refptr<base::SequencedTaskRunner> background_task_runner =
BrowserThread::GetBlockingPool()->GetSequencedTaskRunner( BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
BrowserThread::GetBlockingPool()->GetSequenceToken()); base::SequencedWorkerPool::GetSequenceToken());
Profile* the_profile = static_cast<Profile*>(profile); Profile* the_profile = static_cast<Profile*>(profile);
......
...@@ -282,7 +282,7 @@ void VisitedLinkMaster::InitMembers() { ...@@ -282,7 +282,7 @@ void VisitedLinkMaster::InitMembers() {
used_items_ = 0; used_items_ = 0;
table_size_override_ = 0; table_size_override_ = 0;
suppress_rebuild_ = false; suppress_rebuild_ = false;
sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken(); sequence_token_ = base::SequencedWorkerPool::GetSequenceToken();
} }
bool VisitedLinkMaster::Init() { bool VisitedLinkMaster::Init() {
......
...@@ -14,7 +14,7 @@ scoped_refptr<base::SequencedTaskRunner> ...@@ -14,7 +14,7 @@ scoped_refptr<base::SequencedTaskRunner>
UpdateClientConfig::GetSequencedTaskRunner() const { UpdateClientConfig::GetSequencedTaskRunner() const {
return content::BrowserThread::GetBlockingPool() return content::BrowserThread::GetBlockingPool()
->GetSequencedTaskRunnerWithShutdownBehavior( ->GetSequencedTaskRunnerWithShutdownBehavior(
content::BrowserThread::GetBlockingPool()->GetSequenceToken(), base::SequencedWorkerPool::GetSequenceToken(),
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN); base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment