Commit 23e24b43 authored by oshima@chromium.org's avatar oshima@chromium.org

Reenable WindowSizerContextMenuTest.OpenBrowserUsingContextMenuOnOtherDisplay

To see this is fixed by
https://codereview.chromium.org/245443004/

BUG=346799
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/205243014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266687 0039d316-1c4b-4281-b951-d872f2087c98
parent f7d1d63f
...@@ -69,8 +69,10 @@ void OpenBrowserUsingShelfOnRootWindow(aura::Window* root_window) { ...@@ -69,8 +69,10 @@ void OpenBrowserUsingShelfOnRootWindow(aura::Window* root_window) {
#if defined(OS_WIN) #if defined(OS_WIN)
#define MAYBE_OpenBrowserUsingShelfOnOtherDisplay DISABLED_OpenBrowserUsingShelfOnOtherDisplay #define MAYBE_OpenBrowserUsingShelfOnOtherDisplay DISABLED_OpenBrowserUsingShelfOnOtherDisplay
#define MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay DISABLED_OpenBrowserUsingContextMenuOnOtherDisplay
#else #else
#define MAYBE_OpenBrowserUsingShelfOnOtherDisplay OpenBrowserUsingShelfOnOtherDisplay #define MAYBE_OpenBrowserUsingShelfOnOtherDisplay OpenBrowserUsingShelfOnOtherDisplay
#define MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay OpenBrowserUsingContextMenuOnOtherDisplay
#endif #endif
IN_PROC_BROWSER_TEST_F(WindowSizerTest, IN_PROC_BROWSER_TEST_F(WindowSizerTest,
...@@ -161,9 +163,8 @@ void OpenBrowserUsingContextMenuOnRootWindow(aura::Window* root_window) { ...@@ -161,9 +163,8 @@ void OpenBrowserUsingContextMenuOnRootWindow(aura::Window* root_window) {
} // namespace } // namespace
// Test is flaky: http://crbug.com/346799
IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest, IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest,
DISABLED_OpenBrowserUsingContextMenuOnOtherDisplay) { MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay) {
// Don't shutdown when closing the last browser window. // Don't shutdown when closing the last browser window.
chrome::IncrementKeepAliveCount(); chrome::IncrementKeepAliveCount();
...@@ -174,14 +175,14 @@ IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest, ...@@ -174,14 +175,14 @@ IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest,
BrowserList* browser_list = BrowserList* browser_list =
BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH); BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH);
EXPECT_EQ(1u, browser_list->size()); ASSERT_EQ(1u, browser_list->size());
EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow()); EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow());
CloseBrowser(browser_list->get(0)); CloseBrowser(browser_list->get(0));
OpenBrowserUsingContextMenuOnRootWindow(root_windows[1]); OpenBrowserUsingContextMenuOnRootWindow(root_windows[1]);
// A new browser must be created on 2nd display. // A new browser must be created on 2nd display.
EXPECT_EQ(1u, browser_list->size()); ASSERT_EQ(1u, browser_list->size());
EXPECT_EQ(root_windows[1], EXPECT_EQ(root_windows[1],
browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow()); browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow());
EXPECT_EQ(root_windows[1], ash::Shell::GetTargetRootWindow()); EXPECT_EQ(root_windows[1], ash::Shell::GetTargetRootWindow());
...@@ -189,7 +190,7 @@ IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest, ...@@ -189,7 +190,7 @@ IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest,
OpenBrowserUsingContextMenuOnRootWindow(root_windows[0]); OpenBrowserUsingContextMenuOnRootWindow(root_windows[0]);
// Next new browser must be created on 1st display. // Next new browser must be created on 1st display.
EXPECT_EQ(2u, browser_list->size()); ASSERT_EQ(2u, browser_list->size());
EXPECT_EQ(root_windows[0], EXPECT_EQ(root_windows[0],
browser_list->get(1)->window()->GetNativeWindow()->GetRootWindow()); browser_list->get(1)->window()->GetNativeWindow()->GetRootWindow());
EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow()); EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment