Skip to content

GitLab

T
tangled
Commit 23ea7f24 authored by Stephen Martinis's avatar Stephen Martinis Committed by Commit Bot
Browse files
Options

Revert "Only retry failed tests for layout tests" 

This reverts commit ecb97ada.

Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid

Original change's description:
> Only retry failed tests for layout tests
> 
> Recently layout tests have been fairly flaky; this is causing extra load
> on the CQ. Every time layout tests fails, they are retried without patch
> to determine if the failure is a flake or a failure at tip of tree. This
> means that layout tests are running more than other test suites, and
> since layout tests take a long time to run, we end up consuming more
> capacity from our swarming pool than we should.
> 
> Isolated script tests don't have the ability to retry only the tests
> that failed, which is what other test suites do. This CL changes that so
> that layout tests, when re-run without the patch, retry on the tests that
> fail, which should significantly reduce swarming load and cycle time for
> running layout tests without patch.
> 
> Bug: 533481
> Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
> Reviewed-on: https://chromium-review.googlesource.com/1015843
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551821}

TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 533481
Reviewed-on: https://chromium-review.googlesource.com/1018161Reviewed-by: default avatarStephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551877}
parent d9b02050
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 31 deletions
testing/buildbot/chromium.fyi.json
View file @ 23ea7f24
......@@ -2301,7 +2301,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -2816,7 +2815,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -4815,7 +4813,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -5337,7 +5334,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -7666,7 +7662,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -7695,7 +7690,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -7724,7 +7718,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -8249,7 +8242,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -8421,7 +8413,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
testing/buildbot/chromium.linux.json
View file @ 23ea7f24
......@@ -1394,7 +1394,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
testing/buildbot/chromium.mac.json
View file @ 23ea7f24
......@@ -467,7 +467,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -938,7 +937,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -1409,7 +1407,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -1897,7 +1894,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
testing/buildbot/chromium.webkit.json
View file @ 23ea7f24
......@@ -12,7 +12,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -40,7 +39,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -72,7 +70,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -104,7 +101,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -136,7 +132,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -164,7 +159,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -190,7 +184,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -219,7 +212,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -246,7 +238,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -284,7 +275,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -309,7 +299,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
testing/buildbot/chromium.win.json
View file @ 23ea7f24
......@@ -1786,7 +1786,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -3024,7 +3023,6 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
testing/buildbot/test_suites.pyl
View file @ 23ea7f24
......@@ -550,7 +550,6 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
'swarming': {
'shards': 12,
......@@ -826,7 +825,6 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
'swarming': {
'shards': 12,
......@@ -1099,7 +1097,6 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
'swarming': {
'dimension_sets': [
......@@ -1776,7 +1773,6 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
},
},
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment