Skip to content

GitLab

T
tangled
Commit 24349512 authored by rsesek@chromium.org's avatar rsesek@chromium.org
Browse files
Options

[Mac] Fix the BookmarkMenuBridgeTest.TestAddItemToMenu after r96393. 

BUG=92410
TEST=unit_tests
TBR=avi

Review URL: http://codereview.chromium.org/7619009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96395 0039d316-1c4b-4281-b951-d872f2087c98
parent b29f0e30
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 6 deletions
chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm
View file @ 24349512
...@@ -260,19 +260,19 @@ TEST_F(BookmarkMenuBridgeTest, TestAddItemToMenu) { ...@@ -260,19 +260,19 @@ TEST_F(BookmarkMenuBridgeTest, TestAddItemToMenu) {
IDS_BOOMARK_BAR_OPEN_INCOGNITO, root, menu, true); IDS_BOOMARK_BAR_OPEN_INCOGNITO, root, menu, true);
EXPECT_EQ(3, [menu numberOfItems]); EXPECT_EQ(3, [menu numberOfItems]);
title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL); title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL);
item = [menu itemWithTitle:title]; item = [menu itemWithTitle:title];
EXPECT_TRUE(item); EXPECT_TRUE(item);
EXPECT_EQ(@selector(openAllBookmarks:), [item action]); EXPECT_EQ(@selector(openAllBookmarks:), [item action]);
EXPECT_TRUE([item isEnabled]); EXPECT_TRUE([item isEnabled]);
title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW); title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW);
item = [menu itemWithTitle:title]; item = [menu itemWithTitle:title];
EXPECT_TRUE(item); EXPECT_TRUE(item);
EXPECT_EQ(@selector(openAllBookmarksNewWindow:), [item action]); EXPECT_EQ(@selector(openAllBookmarksNewWindow:), [item action]);
EXPECT_TRUE([item isEnabled]); EXPECT_TRUE([item isEnabled]);
title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_INCOGNITO); title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_INCOGNITO);
item = [menu itemWithTitle:title]; item = [menu itemWithTitle:title];
EXPECT_TRUE(item); EXPECT_TRUE(item);
EXPECT_EQ(@selector(openAllBookmarksIncognitoWindow:), [item action]); EXPECT_EQ(@selector(openAllBookmarksIncognitoWindow:), [item action]);
...@@ -289,19 +289,19 @@ TEST_F(BookmarkMenuBridgeTest, TestAddItemToMenu) { ...@@ -289,19 +289,19 @@ TEST_F(BookmarkMenuBridgeTest, TestAddItemToMenu) {
IDS_BOOMARK_BAR_OPEN_INCOGNITO, root, menu, false); IDS_BOOMARK_BAR_OPEN_INCOGNITO, root, menu, false);
EXPECT_EQ(3, [menu numberOfItems]); EXPECT_EQ(3, [menu numberOfItems]);
title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL); title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL);
item = [menu itemWithTitle:title]; item = [menu itemWithTitle:title];
EXPECT_TRUE(item); EXPECT_TRUE(item);
EXPECT_EQ(nil, [item action]); EXPECT_EQ(nil, [item action]);
EXPECT_FALSE([item isEnabled]); EXPECT_FALSE([item isEnabled]);
title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW); title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW);
item = [menu itemWithTitle:title]; item = [menu itemWithTitle:title];
EXPECT_TRUE(item); EXPECT_TRUE(item);
EXPECT_EQ(nil, [item action]); EXPECT_EQ(nil, [item action]);
EXPECT_FALSE([item isEnabled]); EXPECT_FALSE([item isEnabled]);
title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_INCOGNITO); title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_INCOGNITO);
item = [menu itemWithTitle:title]; item = [menu itemWithTitle:title];
EXPECT_TRUE(item); EXPECT_TRUE(item);
EXPECT_EQ(nil, [item action]); EXPECT_EQ(nil, [item action]);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment