[iOS] Add snackbar for the copy action

This CL adds a snackbar for the copy action from the share menu.
It also consolidates metrics for the different actions of the share
menu.

Bug: 880030, 883642
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9ad39ad2f4f9b34e4d26aacc12a9db1fb2364bb6
Reviewed-on: https://chromium-review.googlesource.com/1224311Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591320}

ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm

@@ -83,8 +83,6 @@ NSString* const kBookmarkActivityType = @"com.google.chrome.bookmarkActivity";
 }
 
 - (void)performActivity {
-  base::RecordAction(
-      base::UserMetricsAction("MobileShareActionBookmarkThisPage"));
   [self.dispatcher bookmarkPage];
   [self activityDidFinish:YES];
 }

ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm

@@ -65,7 +65,6 @@ NSString* const kFindInPageActivityType =
 }
 
 - (void)performActivity {
-  base::RecordAction(base::UserMetricsAction("MobileShareActionFindInPage"));
   [self.dispatcher showFindInPage];
   [self activityDidFinish:YES];
 }

ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm

@@ -75,7 +75,6 @@ NSString* const kReadingListActivityType =
 }
 
 - (void)performActivity {
-  base::RecordAction(base::UserMetricsAction("MobileShareActionReadLater"));
   ReadingListAddCommand* command =
       [[ReadingListAddCommand alloc] initWithURL:_activityURL title:_title];
   [_dispatcher addToReadingList:command];

ios/chrome/browser/ui/activity_services/activity_type_util.h

@@ -10,6 +10,8 @@
 namespace activity_type_util {
 
 enum ActivityType {
+  BOOKMARK,
+  COPY,
   NATIVE_FACEBOOK,
   NATIVE_MAIL,
   NATIVE_MESSAGE,
@@ -17,12 +19,15 @@ enum ActivityType {
   NATIVE_WEIBO,
   NATIVE_CLIPBOARD,
   PRINT,
+  FIND_IN_PAGE,
   GOOGLE_DRIVE,
   GOOGLE_GMAIL,
   GOOGLE_GOOGLEPLUS,
   GOOGLE_HANGOUTS,
   GOOGLE_INBOX,
   GOOGLE_UNKNOWN,
+  READ_LATER,
+  REQUEST_DESKTOP_MOBILE_SITE,
   THIRD_PARTY_MAILBOX,
   THIRD_PARTY_FACEBOOK_MESSENGER,
   THIRD_PARTY_WHATS_APP,

ios/chrome/browser/ui/activity_services/activity_type_util.mm

@@ -71,6 +71,8 @@ struct PrefixTypeAssociation {
 };
 
 const PrefixTypeAssociation prefixTypeAssociations[] = {
+    {BOOKMARK, @"com.google.chrome.bookmarkActivity", true},
+    {COPY, @"com.google.chrome.copyActivity", true},
     {NATIVE_FACEBOOK, @"com.apple.UIKit.activity.PostToFacebook", true},
     {NATIVE_MAIL, @"com.apple.UIKit.activity.Mail", true},
     {NATIVE_MESSAGE, @"com.apple.UIKit.activity.Message", true},
@@ -78,6 +80,7 @@ const PrefixTypeAssociation prefixTypeAssociations[] = {
     {NATIVE_WEIBO, @"com.apple.UIKit.activity.PostToWeibo", true},
     {NATIVE_CLIPBOARD, @"com.apple.UIKit.activity.CopyToPasteboard", true},
     {PRINT, @"com.google.chrome.printActivity", true},
+    {FIND_IN_PAGE, @"com.google.chrome.FindInPageActivityType", true},
     // The trailing '.' prevents false positives.
     // For instance, "com.viberific" won't be matched by the "com.viber.".
     {GOOGLE_DRIVE, @"com.google.Drive.", false},
@@ -86,6 +89,9 @@ const PrefixTypeAssociation prefixTypeAssociations[] = {
     {GOOGLE_HANGOUTS, @"com.google.hangouts.", false},
     {GOOGLE_INBOX, @"com.google.inbox.", false},
     {GOOGLE_UNKNOWN, @"com.google.", false},
+    {READ_LATER, @"com.google.chrome.readingListActivity", true},
+    {REQUEST_DESKTOP_MOBILE_SITE,
+     @"com.google.chrome.requestDesktopOrMobileSiteActivity", true},
     {THIRD_PARTY_MAILBOX, @"com.orchestra.v2.", false},
     {THIRD_PARTY_FACEBOOK_MESSENGER, @"com.facebook.Messenger.", false},
     {THIRD_PARTY_WHATS_APP, @"net.whatsapp.WhatsApp.", false},
@@ -127,6 +133,7 @@ NSString* CompletionMessageForActivity(ActivityType type) {
   // Make sure that the message is meaningful even if the activity completed
   // unsuccessfully.
   switch (type) {
+    case COPY:
     case NATIVE_CLIPBOARD:
       return l10n_util::GetNSString(IDS_IOS_SHARE_TO_CLIPBOARD_SUCCESS);
     case APPEX_PASSWORD_MANAGEMENT:
@@ -141,12 +148,25 @@ void RecordMetricForActivity(ActivityType type) {
     case UNKNOWN:
       base::RecordAction(base::UserMetricsAction("MobileShareMenuUnknown"));
       break;
+    case BOOKMARK:
+      base::RecordAction(base::UserMetricsAction("MobileShareMenuBookmark"));
+      break;
+    case COPY:
     case NATIVE_CLIPBOARD:
       base::RecordAction(base::UserMetricsAction("MobileShareMenuClipboard"));
       break;
+    case FIND_IN_PAGE:
+      base::RecordAction(base::UserMetricsAction("MobileShareMenuFindInPage"));
+      break;
     case PRINT:
       base::RecordAction(base::UserMetricsAction("MobileShareMenuPrint"));
       break;
+    case READ_LATER:
+      base::RecordAction(base::UserMetricsAction("MobileShareMenuReadLater"));
+      break;
+    case REQUEST_DESKTOP_MOBILE_SITE:
+      base::RecordAction(base::UserMetricsAction("MobileShareMenuRequestSite"));
+      break;
     case GOOGLE_GMAIL:
       base::RecordAction(base::UserMetricsAction("MobileShareMenuGmail"));
       break;

tools/metrics/actions/actions.xml

@@ -11604,6 +11604,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="MobileShareActionBookmarkThisPage">
+  <obsolete>Deprecated as of 9/2018</obsolete>
   <owner>gambard@chromium.org</owner>
   <description>
     The user pressed &quot;Bookmark&quot; from the share action menu.
@@ -11611,6 +11612,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="MobileShareActionFindInPage">
+  <obsolete>Deprecated as of 9/2018</obsolete>
   <owner>gambard@chromium.org</owner>
   <description>
     The user pressed &quot;Find In Page&quot; from the share action menu.
@@ -11618,6 +11620,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="MobileShareActionReadLater">
+  <obsolete>Deprecated as of 9/2018</obsolete>
   <owner>gambard@chromium.org</owner>
   <description>
     The user pressed &quot;Read Later&quot; from the share action menu.
@@ -11628,7 +11631,8 @@ should be able to be added at any place in this file.
   <owner>gambard@chromium.org</owner>
   <description>
     The user pressed &quot;Request Desktop Site&quot; from the share action
-    menu.
+    menu. This action is logged in addition to MobileShareMenuRequestSite to
+    disambiguate between desktop and mobile.
   </description>
 </action>
 
@@ -11636,6 +11640,33 @@ should be able to be added at any place in this file.
   <owner>gambard@chromium.org</owner>
   <description>
     The user pressed &quot;Request Mobile Site&quot; from the share action menu.
+    This action is logged in addition to MobileShareMenuRequestSite to
+    disambiguate between desktop and mobile.
+  </description>
+</action>
+
+<action name="MobileShareMenuBookmark">
+  <owner>gambard@chromium.org</owner>
+  <description>User shared to the device's bookmarks.</description>
+</action>
+
+<action name="MobileShareMenuFindInPage">
+  <owner>gambard@chromium.org</owner>
+  <description>
+    User activated the device's FindInPage from the share menu.
+  </description>
+</action>
+
+<action name="MobileShareMenuReadLater">
+  <owner>gambard@chromium.org</owner>
+  <description>User shared to the device's Reading List.</description>
+</action>
+
+<action name="MobileShareMenuRequestSite">
+  <owner>gambard@chromium.org</owner>
+  <description>
+    User requested the desktop or mobile version of a site web from the share
+    menu.
   </description>
 </action>