Commit 24436c3d authored by Arthur Hemery's avatar Arthur Hemery Committed by Commit Bot

Removing non-functional skip in WillSendRequest.

If condition used pending_navigation_params_ that is always false there.
Usage might have been corrupted during refactorings without being noticed,
or was never working.

Skip was removed, CHECK added as well as a TODO to reintroduce the
functionality.

Bug: 882800
Change-Id: I0cafc9dda082a395d48783cac03ec0d25a1ec73e
Reviewed-on: https://chromium-review.googlesource.com/1202462Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590352}
parent 66e55526
...@@ -4832,13 +4832,9 @@ void RenderFrameImpl::FrameRectsChanged(const blink::WebRect& frame_rect) { ...@@ -4832,13 +4832,9 @@ void RenderFrameImpl::FrameRectsChanged(const blink::WebRect& frame_rect) {
} }
void RenderFrameImpl::WillSendRequest(blink::WebURLRequest& request) { void RenderFrameImpl::WillSendRequest(blink::WebURLRequest& request) {
if (request.GetFrameType() != CHECK(!pending_navigation_params_);
network::mojom::RequestContextFrameType::kNone && // TODO(ahemery): We should skip the processing for the main resource, it has
pending_navigation_params_) { // been done before sending the request to the browser.
// Skip the processing for the main resource, it has been done before
// sending the request to the browser.
return;
}
if (render_view_->renderer_preferences_.enable_do_not_track) if (render_view_->renderer_preferences_.enable_do_not_track)
request.SetHTTPHeaderField(blink::WebString::FromUTF8(kDoNotTrackHeader), request.SetHTTPHeaderField(blink::WebString::FromUTF8(kDoNotTrackHeader),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment