Revert "[Nearby] Validate device name in onboarding."

This reverts commit 920451c0.

Reason for revert: suspect causing browertests failure on linux-chromeos-dbg
browser_tests failed because of:
- NearbyOnboardingPageTest.All

First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20674

Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867535501208450768/+/steps/browser_tests/0/logs/Deterministic_failure:_NearbyOnboardingPageTest.All__status_FAILURE_/0
---
 ReferenceError: loadTimeData is not defined
     at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/nearby_share/shared/nearby_onboarding_page_test.js:50:5)
---

Original change's description:
> [Nearby] Validate device name in onboarding.
>
> This adds support for validating the device name that a user enters
> during the Nearby Share onboarding flow. Validation happens as the user
> types and also when they try to proceed to the next screen. If an
> invalid name is detected, an error message will appear and the "Next"
> button will be disabled.
>
> Screenshots:
>   https://screenshot.googleplex.com/3USR7ftg7QCwJhR.png
>   https://screenshot.googleplex.com/6Cr6pedUxWnUKju.png
>
> Bug: b:169582004
> Change-Id: I07d4822e0ea099b30d23ed34a5f70f01940a3009
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441150
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: James Vecore <vecore@google.com>
> Commit-Queue: Michael Hansen <hansenmichael@google.com>
> Cr-Commit-Position: refs/heads/master@{#813193}

TBR=khorimoto@chromium.org,vecore@google.com,hansenmichael@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:169582004
Change-Id: I6a9dd1f9f40c6f54e6a467de3053b75f8f264645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448510Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#813624}

chrome/browser/resources/nearby_share/shared/nearby_onboarding_page.html

@@ -5,7 +5,6 @@
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="./nearby_page_template.html">
-<link rel="import" href="./nearby_share_settings.html">
 <link rel="import" href="./nearby_share_settings_behavior.html">
 
 <dom-module id="nearby-onboarding-page">
@@ -48,7 +47,6 @@
         sub-title="$i18n{nearbyShareOnboardingPageSubtitle}"
         action-button-label="$i18n{nearbyShareActionsNext}"
         action-button-event-name="next"
-        action-disabled="[[hasErrorMessage_(errorMessage)]]"
         cancel-button-label="$i18n{nearbyShareActionsCancel}"
         cancel-button-event-name="close">
       <div id=center-content slot="content">
@@ -57,9 +55,7 @@
         </iron-icon>
         <div id="device-name-column">
           <cr-input label="$i18n{nearbyShareOnboardingPageDeviceName}"
-              id="deviceName" value="[[settings.deviceName]]"
-              on-input="onDeviceNameInput_" error-message="[[errorMessage]]"
-              invalid="[[hasErrorMessage_(errorMessage)]]" autofocus>
+              id="deviceName" value="[[settings.deviceName]]" autofocus>
           </cr-input>
         </div>
       </div>

chrome/browser/resources/nearby_share/shared/nearby_onboarding_page.js

@@ -16,13 +16,7 @@ Polymer({
     /** @type {?nearby_share.NearbySettings} */
     settings: {
       type: Object,
-    },
-
-    /** @type {string} */
-    errorMessage: {
-      type: String,
-      value: '',
-    },
+    }
   },
 
   listeners: {
@@ -33,57 +27,7 @@ Polymer({
    * @private
    */
   onNext_() {
-    nearby_share.getNearbyShareSettings()
-        .setDeviceName(this.$.deviceName.value)
-        .then((result) => {
-          this.updateErrorMessage_(result.result);
-          if (result.result ===
-              nearbyShare.mojom.DeviceNameValidationResult.kValid) {
-            this.fire('change-page', {page: 'visibility'});
-          }
-        });
-  },
-
-  /** @private */
-  onDeviceNameInput_() {
-    nearby_share.getNearbyShareSettings()
-        .validateDeviceName(this.$.deviceName.value)
-        .then((result) => {
-          this.updateErrorMessage_(result.result);
-        });
-  },
-
-  /**
-   * @private
-   *
-   * @param {!nearbyShare.mojom.DeviceNameValidationResult} validationResult The
-   *     error status from validating the provided device name.
-   */
-  updateErrorMessage_(validationResult) {
-    switch (validationResult) {
-      case nearbyShare.mojom.DeviceNameValidationResult.kErrorEmpty:
-        this.errorMessage = this.i18n('nearbyShareDeviceNameEmptyError');
-        break;
-      case nearbyShare.mojom.DeviceNameValidationResult.kErrorTooLong:
-        this.errorMessage = this.i18n('nearbyShareDeviceNameTooLongError');
-        break;
-      case nearbyShare.mojom.DeviceNameValidationResult.kErrorNotValidUtf8:
-        this.errorMessage =
-            this.i18n('nearbyShareDeviceNameInvalidCharactersError');
-        break;
-      default:
-        this.errorMessage = '';
-        break;
-    }
+    this.set('settings.deviceName', this.$.deviceName.value);
+    this.fire('change-page', {page: 'visibility'});
   },
-
-  /**
-   * @private
-   *
-   * @param {!string} errorMessage The error message.
-   * @return {boolean} Whether or not the error message exists.
-   */
-  hasErrorMessage_(errorMessage) {
-    return errorMessage !== '';
-  }
 });

chrome/browser/resources/nearby_share/shared/nearby_shared.gni

@@ -3,7 +3,6 @@
 # found in the LICENSE file.
 
 nearby_shared_auto_imports = [
-  "chrome/browser/resources/nearby_share/shared/nearby_share_settings.html|getNearbyShareSettings",
   "chrome/browser/resources/nearby_share/shared/nearby_share_settings_behavior.html|NearbyShareSettingsBehavior,NearbySettings",
   "chrome/browser/resources/nearby_share/shared/nearby_contact_manager.html|getContactManager,observeContactManager",
   "ui/webui/resources/html/assert.html|assert,assertNotReached",

chrome/test/data/webui/nearby_share/shared/BUILD.gn

@@ -66,9 +66,7 @@ js_library("nearby_onboarding_page_test.m") {
   deps = [
     ":fake_nearby_share_settings.m",
     "../..:chai_assert",
-    "../..:test_util.m",
     "//chrome/browser/resources/nearby_share/shared:nearby_onboarding_page.m",
-    "//ui/webui/resources/cr_elements/cr_input:cr_input.m",
   ]
   extra_deps = [ ":modulize" ]
   externs_list = [ "$externs_path/mocha-2.5.js" ]

chrome/test/data/webui/nearby_share/shared/nearby_onboarding_page_test.js

@@ -3,14 +3,8 @@
 // found in the LICENSE file.
 
 // clang-format off
-// #import 'chrome://nearby/strings.m.js';
 // #import 'chrome://nearby/shared/nearby_onboarding_page.m.js';
-// #import {loadTimeData} from 'chrome://resources/js/load_time_data.m.js';
-// #import {setContactManagerForTesting} from 'chrome://nearby/shared/nearby_contact_manager.m.js';
-// #import {setNearbyShareSettingsForTesting} from 'chrome://nearby/shared/nearby_share_settings.m.js';
-// #import {FakeNearbyShareSettings} from './fake_nearby_share_settings.m.js';
-// #import {assertEquals, assertTrue, assertFalse} from '../../chai_assert.js';
-// #import {waitAfterNextRender} from '../../test_util.m.js';
+// #import {assertEquals} from '../../chai_assert.js';
 // clang-format on
 
 suite('nearby-onboarding-page', function() {
@@ -18,14 +12,8 @@ suite('nearby-onboarding-page', function() {
   let element;
   /** @type {!string} */
   const deviceName = 'Test\'s Device';
-  /** @type {!nearby_share.FakeNearbyShareSettings} */
-  let fakeSettings;
 
   setup(function() {
-    fakeSettings = new nearby_share.FakeNearbyShareSettings();
-    fakeSettings.setEnabled(true);
-    nearby_share.setNearbyShareSettingsForTesting(fakeSettings);
-
     document.body.innerHTML = '';
 
     element = /** @type {!NearbyOnboardingPageElement} */ (
@@ -45,30 +33,4 @@ suite('nearby-onboarding-page', function() {
     // Verify the device name is shown correctly.
     assertEquals(deviceName, element.$$('#deviceName').value);
   });
-
-  test('validate device name preference', async () => {
-    loadTimeData.overrideValues({
-      'nearbyShareDeviceNameEmptyError': 'non-empty',
-      'nearbyShareDeviceNameTooLongError': 'non-empty',
-      'nearbyShareDeviceNameInvalidCharactersError': 'non-empty'
-    });
-
-    const input = /** @type {!CrInputElement} */ (element.$$('#deviceName'));
-    const pageTemplate = element.$$('nearby-page-template');
-
-    fakeSettings.setNextDeviceNameResult(
-        nearbyShare.mojom.DeviceNameValidationResult.kErrorEmpty);
-    input.fire('input');
-    // Allow the validation promise to resolve.
-    await test_util.waitAfterNextRender(/** @type {!HTMLElement} */ (input));
-    assertTrue(input.invalid);
-    assertTrue(pageTemplate.actionDisabled);
-
-    fakeSettings.setNextDeviceNameResult(
-        nearbyShare.mojom.DeviceNameValidationResult.kValid);
-    input.fire('input');
-    await test_util.waitAfterNextRender(/** @type {!HTMLElement} */ (input));
-    assertFalse(input.invalid);
-    assertFalse(pageTemplate.actionDisabled);
-  });
 });

chrome/test/data/webui/settings/chromeos/nearby_share_receive_dialog_tests.js

@@ -5,10 +5,9 @@
 // clang-format off
 // #import {assertEquals} from '../../chai_assert.js';
 // #import {isChildVisible, waitAfterNextRender} from '../../test_util.m.js';
-// #import {setNearbyShareSettingsForTesting, setReceiveManagerForTesting, setContactManagerForTesting} from 'chrome://os-settings/chromeos/os_settings.js';
+// #import {setReceiveManagerForTesting, setContactManagerForTesting} from 'chrome://os-settings/chromeos/os_settings.js';
 // #import {flush} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
 // #import {FakeContactManager} from '../../nearby_share/shared/fake_nearby_contact_manager.m.js';
-// #import {FakeNearbyShareSettings} from '../../nearby_share/shared/fake_nearby_share_settings.m.js';
 // #import {FakeReceiveManager} from './fake_receive_manager.m.js'
 // clang-format on
 
@@ -19,8 +18,6 @@ suite('NearbyShare', function() {
   let fakeReceiveManager;
   /** @type {!nearby_share.FakeContactManager} */
   let fakeContactManager;
-  /** @type {!nearby_share.FakeNearbyShareSettings} */
-  let fakeSettings;
 
   /**
    * This allows both sub-suites to share the same setup logic but with a
@@ -30,12 +27,9 @@ suite('NearbyShare', function() {
   function sharedSetup(enabled) {
     fakeReceiveManager = new nearby_share.FakeReceiveManager();
     fakeContactManager = new nearby_share.FakeContactManager();
-    fakeSettings = new nearby_share.FakeNearbyShareSettings();
-    fakeSettings.setEnabled(true);
 
     nearby_share.setReceiveManagerForTesting(fakeReceiveManager);
     nearby_share.setContactManagerForTesting(fakeContactManager);
-    nearby_share.setNearbyShareSettingsForTesting(fakeSettings);
 
     PolymerTest.clearBody();
 

chrome/test/data/webui/settings/chromeos/os_settings_browsertest.js

@@ -1129,7 +1129,6 @@ var OSSettingsNearbyShareReceiveDialogTest =
   get extraLibraries() {
     return super.extraLibraries.concat([
       '../../nearby_share/shared/fake_nearby_contact_manager.js',
-      '../../nearby_share/shared/fake_nearby_share_settings.js',
       '../../test_util.js',
       '../../test_browser_proxy.js',
       'fake_receive_manager.js',