[iOS][Dark Mode] Support dark mode on overscroll actions

Bug: 986804, 987907
Change-Id: Ibf4b7664100f9d318c2110017ea631dc28d66866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713536
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682247}

ios/chrome/browser/overscroll_actions/BUILD.gn

@@ -30,6 +30,7 @@ source_set("unit_tests") {
     "//base/test:test_support",
     "//ios/chrome/browser/browser_state:test_support",
     "//ios/chrome/browser/ui/overscroll_actions",
+    "//ios/chrome/common/colors",
     "//ios/chrome/test/fakes",
     "//ios/web/public",
     "//ios/web/public/test",

ios/chrome/browser/overscroll_actions/overscroll_actions_tab_helper_unittest.mm

@@ -10,6 +10,8 @@
 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
 #import "ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h"
 #import "ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.h"
+#import "ios/chrome/common/colors/incognito_color_util.h"
+#import "ios/chrome/common/colors/semantic_color_names.h"
 #import "ios/chrome/test/fakes/fake_overscroll_actions_controller_delegate.h"
 #import "ios/web/public/test/fakes/test_web_state.h"
 #include "ios/web/public/test/test_web_thread_bundle.h"
@@ -112,9 +114,7 @@ TEST_F(OverscrollActionsTabHelperTest, MAYBE_TestRegularBrowserStateStyle) {
   web_state_.SetBrowserState(browser_state_.get());
   overscroll_tab_helper()->SetDelegate(overscroll_delegate_);
   SimulatePullForRefreshAction();
-  UIColor* expected_color =
-      [UIColor colorWithWhite:kActionViewBackgroundColorBrightnessNonIncognito
-                        alpha:1.0];
+  UIColor* expected_color = [UIColor colorNamed:kBackgroundColor];
   EXPECT_TRUE(action_view());
   EXPECT_NSEQ(expected_color, action_view().backgroundColor);
 }
@@ -135,9 +135,11 @@ TEST_F(OverscrollActionsTabHelperTest,
       browser_state_->GetOffTheRecordChromeBrowserState());
   overscroll_tab_helper()->SetDelegate(overscroll_delegate_);
   SimulatePullForRefreshAction();
+  // For iOS 13 and dark mode, the incognito overscroll actions view uses a
+  // dynamic color.
   UIColor* expected_color =
-      [UIColor colorWithWhite:kActionViewBackgroundColorBrightnessIncognito
-                        alpha:1.0];
+      color::IncognitoDynamicColor(true, [UIColor colorNamed:kBackgroundColor],
+                                   [UIColor colorNamed:kBackgroundDarkColor]);
   EXPECT_TRUE(action_view());
   EXPECT_NSEQ(expected_color, action_view().backgroundColor);
 }

ios/chrome/browser/ui/overscroll_actions/BUILD.gn

@@ -34,6 +34,7 @@ source_set("overscroll_actions") {
     "//ios/chrome/browser/ui/toolbar/public",
     "//ios/chrome/browser/ui/util",
     "//ios/chrome/browser/ui/voice",
+    "//ios/chrome/common/colors",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser/ui",
     "//ios/web/common",

ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

@@ -367,7 +367,7 @@ NSString* const kOverscrollActionsDidEnd = @"OverscrollActionsDidStop";
 }
 
 - (void)setStyle:(OverscrollStyle)style {
-  [self.overscrollActionView setStyle:style];
+  self.overscrollActionView.style = style;
 }
 
 #pragma mark - webViewScrollView and UIScrollView delegates implementations

ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.h

@@ -58,6 +58,8 @@ extern const CGFloat kActionViewBackgroundColorBrightnessIncognito;
 @property(nonatomic, strong, readonly) UIView* backgroundView;
 // Whether cropping is set on the selection circle (true by default).
 @property(nonatomic, assign) BOOL selectionCroppingEnabled;
+// The current style of the overscroll actions UI.
+@property(nonatomic, assign) OverscrollStyle style;
 
 @property(nonatomic, assign) id<OverscrollActionsViewDelegate> delegate;
 
@@ -82,9 +84,6 @@ extern const CGFloat kActionViewBackgroundColorBrightnessIncognito;
 // action has been selected.
 - (void)displayActionAnimation;
 
-// Sets the style of the overscroll action UI.
-- (void)setStyle:(OverscrollStyle)style;
-
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_OVERSCROLL_ACTIONS_OVERSCROLL_ACTIONS_VIEW_H_