Commit 24739707 authored by Peter Boström's avatar Peter Boström Committed by Commit Bot

Prevent double focus effect in IconLabelBubbleView

IconLabelBubbleView::AnimationEnded used to call
GetInkDrop()->SetShowHighlightOnFocus(true) to restore the original
InkDrop highlight state before this change. This is incorrect as the
initial highlight focus depends on the presence of a focus ring.

This changes the call to restore highlight-on-focus based on the
presence of a focus ring instead of unconditionally highlighting.

Bug: chromium:1025152
Change-Id: I5e6d563bc012a16a5bf4a63404375c4d4d1418e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949034
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: default avatarCaroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721156}
parent 6517b488
......@@ -363,7 +363,7 @@ void IconLabelBubbleView::AnimationEnded(const gfx::Animation* animation) {
}
GetInkDrop()->SetShowHighlightOnHover(true);
GetInkDrop()->SetShowHighlightOnFocus(true);
GetInkDrop()->SetShowHighlightOnFocus(!focus_ring());
}
void IconLabelBubbleView::AnimationProgressed(const gfx::Animation* animation) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment