wpt expectations updater: Discard empty |versions| in simplify_specifiers()
Since commit 4874fdef ("[blinkpy] Stop rebaselining on Android bots"), android_blink_rel is no longer part of the rebaselining bots used by wpt-importer. However, 'android' is still part of Port.CONFIGURATION_SPECIFIER_MACROS, which is passed as |specifier_macros| to simplify_specifiers(). And since Android is no longer covered by trybots, |versions| in that function ends up an empty set, which by definition means all its elements are in |specifiers|. In practice, this means that a test such as external/wpt/preload/onload-event.html, which was failing on some Mac bots, would cause simplify_specifiers() to return something like ['Android', 'Mac10.10'] and we would try to add repeated lines to TestExpectations that look like crbug.com/626703 [ Android ] foo [ Failure Timeout ] crbug.com/626703 [ Mac10.13 ] foo [ Failure Timeout ] crbug.com/626703 [ Android ] foo [ Failure Timeout ] crbug.com/626703 [ Mac10.12 ] foo [ Failure Timeout ] which fails our presubmit checks as expected. Fix it by not taking empty sets into consideration when looping. This unblocks WPT imports again. Bug: 567947 Change-Id: Ia471cad213192fa23425d5e8eecf47457605f9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631663 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#663740}
Showing
Please register or sign in to comment