Commit 248ce308 authored by horo@chromium.org's avatar horo@chromium.org

Fix flakiness of ServiceWorkerBrowserTest.Reload by using TitleWatcher.

BUG=393486

Review URL: https://codereview.chromium.org/451943003

Cr-Commit-Position: refs/heads/master@{#288301}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288301 0039d316-1c4b-4281-b951-d872f2087c98
parent c0903e17
......@@ -25,6 +25,7 @@
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
#include "content/shell/browser/shell.h"
......@@ -670,7 +671,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, SyncEventHandled) {
EXPECT_EQ(200, response.status_code);
}
IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, DISABLED_Reload) {
IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, Reload) {
const std::string kPageUrl = "/service_worker/reload.html";
const std::string kWorkerUrl = "/service_worker/fetch_event_reload.js";
{
......@@ -683,12 +684,18 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, DISABLED_Reload) {
base::Bind(&ExpectResultAndRun, true, base::Bind(&base::DoNothing)));
observer->Wait();
}
NavigateToURL(shell(), embedded_test_server()->GetURL(kPageUrl));
EXPECT_EQ(base::UTF8ToUTF16("reload=false"),
shell()->web_contents()->GetTitle());
ReloadBlockUntilNavigationsComplete(shell(), 1);
EXPECT_EQ(base::UTF8ToUTF16("reload=true"),
shell()->web_contents()->GetTitle());
{
const base::string16 title = base::ASCIIToUTF16("reload=false");
TitleWatcher title_watcher(shell()->web_contents(), title);
NavigateToURL(shell(), embedded_test_server()->GetURL(kPageUrl));
EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
}
{
const base::string16 title = base::ASCIIToUTF16("reload=true");
TitleWatcher title_watcher(shell()->web_contents(), title);
ReloadBlockUntilNavigationsComplete(shell(), 1);
EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
}
shell()->Close();
{
base::RunLoop run_loop;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment